Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate products to NPM automation when it makes sense #2071

Closed
marcwrobel opened this issue Dec 16, 2022 · 7 comments · Fixed by #2132
Closed

Migrate products to NPM automation when it makes sense #2071

marcwrobel opened this issue Dec 16, 2022 · 7 comments · Fixed by #2132
Assignees
Labels
enhancement New feature or request

Comments

@marcwrobel
Copy link
Member

Now that NPM automation has been merged (endoflife-date/release-data#36), we must have a look at all the products to see if they can/should use it.

Example : Vue migrated to NPM automation because it was simpler (6017e87).

@marcwrobel marcwrobel added the enhancement New feature or request label Dec 16, 2022
@marcwrobel marcwrobel changed the title Migrate products to NPM automation when Migrate products to NPM automation when it makes sense Dec 16, 2022
@captn3m0
Copy link
Member

captn3m0 commented Dec 16, 2022

Other relevant pages with mention of Javascript:

  • EmberJS
  • jQuery
  • React
  • Bootstrap
  • Electron

Switching makes sense for all of these - NPM automation is much faster. However, NPM does seem to return rc/alpha/beta releases. And there's yanked releases as well that we should ignore.

So switching one by one probably makes sense. If you'd like to do this, our automation has some easier testing methods as well, so you don't have to test locally:

  1. File PR on this repo to change auto configuration. This must be a local branch, not on a fork
  2. Create a new branch with the same name on release-data repo. You can create it from the UI with the branch switcher.
    image
  3. Hopefully the action runs successfully, generates the right release files. You can then merge the PRs.

@captn3m0
Copy link
Member

https://www.npmjs.com/package/kotlin?activeTab=versions

Surprisingly, Kotlin's standard library (published on NPM) is a good proxy for accurate Kotlin release dates. The git tags were quite inaccurate so this will be nice.,

@captn3m0
Copy link
Member

Will take these up.

@marcwrobel
Copy link
Member Author

marcwrobel commented Dec 21, 2022

Created #2132 to see how it behave (using the corresponding PR in release-data: endoflife-date/release-data#52).

@captn3m0 captn3m0 removed their assignment Dec 22, 2022
@marcwrobel
Copy link
Member Author

A few notes (based on endoflife-date/release-data@e0886cb).

Bootstrap:

Electron:

Ember:

jquery:

Kotlin:

React :

  • NPM adds 0.x versions
  • A dozen dates were updated (usually by a day)

@marcwrobel
Copy link
Member Author

Proposal:

  • boostrap: keep git - most date are in sync between git and npm.
  • electron: use npm - a lot of dates would be more accurate and unreleased version would be removed. 1.x versions are not displayed on https://endoflife.date/electron so it's not a big deal if we loose them.
  • ember: use npm - a lot of dates would be more accurate. 1.x and 2.x versions are not displayed on https://endoflife.date/ember so it's not a big deal if we loose them.
  • jquery: keep git - most date are in sync between git and npm, and git allows us to retrieve more versions.
  • kotlin: use npm - I think a lot of dates would be more accurate, even if not perfect (only checked the latest release dates for all release cycles).
  • react: use npm - a few dates would be more accurate, not sure about the 0.x version thought (maybe they should be excluded ?)

@captn3m0, what do you think ? Should we do one PR or multiple PRs ?

@captn3m0
Copy link
Member

Agree with all of the above. Single PR is fine.

marcwrobel added a commit that referenced this issue Dec 27, 2022
- NPM does not contain versions before 3.1.1
- NPM and git dates are in sync
marcwrobel added a commit that referenced this issue Dec 27, 2022
- git contains tags for unreleased versions (such as 9.0.6)
- NPM dates are more accurate (for 100+ versions)
- NPM is missing versions from 1.0.0 to 1.3.0
- NPM adds 0.x releases (maybe those should be removed)
marcwrobel added a commit that referenced this issue Dec 27, 2022
- git contains tags for unreleased versions (such as 9.0.6)
- NPM dates are more accurate (for 100+ versions, usually by a day)
- NPM is missing versions from 1.0.0 to 1.3.0
- NPM adds 0.x releases (maybe those should be removed)
marcwrobel added a commit that referenced this issue Dec 27, 2022
- NPM dates are more accurate (usually by a day)
- NPM does not contain version 1.0.0 to 2.11.0 (see https://www.npmjs.com/package/ember-source)
marcwrobel added a commit that referenced this issue Dec 27, 2022
- NPM is missing a lot of versions (up to 1.10.2, between 2.0.0 to 2.0.3)
- NPM and git dates are mostly in sync.
marcwrobel added a commit that referenced this issue Dec 27, 2022
- NPM looks a lot more accurate than git (by 1 to 6 days)
- NPM is missing a few 1.x version (see https://www.npmjs.com/package/kotlin)
marcwrobel added a commit that referenced this issue Dec 27, 2022
- NPM dates are more accurate than git (usually by a day)
- NPM adds 0.x versions (not sure it should be kept)
@marcwrobel marcwrobel self-assigned this Dec 27, 2022
marcwrobel added a commit that referenced this issue Dec 28, 2022
- NPM does not contain versions before 3.1.1
- NPM and git dates are in sync
marcwrobel added a commit that referenced this issue Dec 28, 2022
- git contains tags for unreleased versions (such as 9.0.6)
- NPM dates are more accurate (for 100+ versions, usually by a day)
- NPM is missing versions from 1.0.0 to 1.3.0
- NPM adds 0.x releases (maybe those should be removed)
marcwrobel added a commit that referenced this issue Dec 28, 2022
- NPM dates are more accurate (usually by a day)
- NPM does not contain version 1.0.0 to 2.11.0 (see https://www.npmjs.com/package/ember-source)
marcwrobel added a commit that referenced this issue Dec 28, 2022
- NPM is missing a lot of versions (up to 1.10.2, between 2.0.0 to 2.0.3)
- NPM and git dates are mostly in sync.
marcwrobel added a commit that referenced this issue Dec 28, 2022
- NPM looks a lot more accurate than git (by 1 to 6 days)
- NPM is missing a few 1.x version (see https://www.npmjs.com/package/kotlin)
marcwrobel added a commit that referenced this issue Dec 28, 2022
- NPM dates are more accurate than git (usually by a day)
- NPM adds 0.x versions (not sure it should be kept)
marcwrobel added a commit that referenced this issue Jan 4, 2023
It was off-sync because of the switch to NPM automation (#2071).
marcwrobel added a commit that referenced this issue Jan 5, 2023
It was off-sync because of the switch to NPM automation (#2071).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants