Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cos] Mark everything as LTS #2055

Merged
merged 3 commits into from
Dec 15, 2022
Merged

[cos] Mark everything as LTS #2055

merged 3 commits into from
Dec 15, 2022

Conversation

captn3m0
Copy link
Member

@captn3m0 captn3m0 commented Dec 15, 2022

Since all releases are technically LTS, either we mark all as LTS or none of them as LTS. Going for the latter, as discussed in #2050.

Decided to mark everything as LTS because we explicitly use the LTS language in the prose. For that to make sense, releases above must be marked as LTS, so we mark all of them to match.

Also fixed up the confusing column names.

Preview: https://deploy-preview-2055--endoflife-date.netlify.app/cos

Since all releases are technically LTS, either we mark all as LTS
or none of them as LTS. Going for the latter, as discussed in #2050
@captn3m0 captn3m0 added the product-fixes Product content or release fixes that do not count as updates label Dec 15, 2022
@captn3m0 captn3m0 self-assigned this Dec 15, 2022
decided the other way around, since the text explicitly mentions:

> support commitment applies only to the LTS

If someone reads this, they expect the table above to include LTS
markers. Having such a marker for all of them is better to make it
easier to understand.

It's also technically correct
@captn3m0 captn3m0 mentioned this pull request Dec 15, 2022
@captn3m0 captn3m0 changed the title [cos] Remove LTS tags [cos] Mark everything as LTS Dec 15, 2022
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcwrobel marcwrobel merged commit f1e0a56 into master Dec 15, 2022
@marcwrobel marcwrobel deleted the cos-lts-change branch December 15, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product-fixes Product content or release fixes that do not count as updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants