Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Product] SQLite #2442

Merged
merged 13 commits into from
Feb 13, 2023
Merged

[New Product] SQLite #2442

merged 13 commits into from
Feb 13, 2023

Conversation

adriens
Copy link
Contributor

@adriens adriens commented Feb 2, 2023

@adriens adriens changed the title [Request - Product] SQLite feather [Request - Product] SQLite 🪶 Feb 2, 2023
@adriens
Copy link
Contributor Author

adriens commented Feb 2, 2023

❔ Would you like me to add links to each cycle ❔

@marcwrobel marcwrobel changed the title [Request - Product] SQLite 🪶 [Request - Product] SQLite Feb 3, 2023
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adriens, thank you for this PR, I left you a few notes.

Remember there is a preview available on https://deploy-preview-2442--endoflife-date.netlify.app/sqlite.

products/sqlite.md Show resolved Hide resolved
products/sqlite.md Outdated Show resolved Hide resolved
products/sqlite.md Outdated Show resolved Hide resolved
products/sqlite.md Outdated Show resolved Hide resolved
products/sqlite.md Outdated Show resolved Hide resolved
products/sqlite.md Outdated Show resolved Hide resolved
products/sqlite.md Outdated Show resolved Hide resolved
products/sqlite.md Outdated Show resolved Hide resolved
products/sqlite.md Show resolved Hide resolved
@marcwrobel marcwrobel added the new-product This PR adds a new product to the website. label Feb 3, 2023
@marcwrobel marcwrobel changed the title [Request - Product] SQLite [New Product] SQLite Feb 8, 2023
@captn3m0
Copy link
Member

captn3m0 commented Feb 8, 2023

+1 to switching to major versions.

Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but requires a review by @adriens and by another @endoflife-date/everyone collaborator.

@usta
Copy link
Member

usta commented Feb 13, 2023 via email

@marcwrobel
Copy link
Member

for example releaseDate is at the bottom in cycle 3

You are right I fixed it. Anyway it's not that important since releaseDate may be updated by the auto-update (and moved to the bottom of the block).

Appart from that LGTM.

@marcwrobel marcwrobel requested a review from usta February 13, 2023 18:11
@usta
Copy link
Member

usta commented Feb 13, 2023 via email

@marcwrobel marcwrobel merged commit 1682e4b into endoflife-date:master Feb 13, 2023
@adriens adriens deleted the patch-12 branch February 15, 2023 06:40
@adriens
Copy link
Contributor Author

adriens commented Feb 15, 2023

🎦 https://youtu.be/7Cu0saF6Ce4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-product This PR adds a new product to the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants