-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Product] SQLite #2442
[New Product] SQLite #2442
Conversation
❔ Would you like me to add links to each cycle ❔ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adriens, thank you for this PR, I left you a few notes.
Remember there is a preview available on https://deploy-preview-2442--endoflife-date.netlify.app/sqlite.
+1 to switching to major versions. |
https://sqlite.org/com/tech.html is the only page where it is stated that only the latest version is supported.
sqlite3 is a python library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but requires a review by @adriens and by another @endoflife-date/everyone collaborator.
for example releaseDate is at the bottom in cycle 3
13 Şub 2023 Pzt 12:02 tarihinde Marc Wrobel ***@***.***> şunu
yazdı:
… ***@***.**** commented on this pull request.
------------------------------
In products/sqlite.md
<#2442 (comment)>
:
> +eolColumn: Support Status
+
+# This git mirror only contains versions from 3.6.10.
+auto:
+- git: https://github.com/sqlite/sqlite.git
+ regex: '^version-(?<major>\d+)\.(?<minor>\d+)(\.(?<patch>\d+))?$'
+
+releases:
+- releaseCycle: "3"
+ eol: false
+ latest: "3.40.1"
+ latestReleaseDate: 2022-12-28
+ releaseDate: 2004-06-18
+
+- releaseCycle: "2"
+ releaseDate: 2001-09-28
Why ? It looks already normalized to me.
—
Reply to this email directly, view it on GitHub
<#2442 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3R4VVOWLPKAJWRZ5EBH3WXH2ARANCNFSM6AAAAAAUO3OSCU>
.
You are receiving this because you are on a team that was mentioned.Message
ID: ***@***.***>
|
You are right I fixed it. Anyway it's not that important since Appart from that LGTM. |
LGTM , I am away from my home so i couldnt approve on github
13 Şub 2023 Pzt 21:11 tarihinde Marc Wrobel ***@***.***> şunu
yazdı:
… @marcwrobel <https://github.com/marcwrobel> requested your review on:
#2442 <#2442> [New
Product] SQLite.
—
Reply to this email directly, view it on GitHub
<#2442 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3R4Q3YDOGKSHTH5Y76UTWXJ2NPANCNFSM6AAAAAAUO3OSCU>
.
You are receiving this because your review was requested.Message ID:
***@***.***
com>
|
cf :