Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api] Mark link as nullable #2483

Merged
merged 1 commit into from
Feb 9, 2023
Merged

[api] Mark link as nullable #2483

merged 1 commit into from
Feb 9, 2023

Conversation

captn3m0
Copy link
Member

@captn3m0 captn3m0 commented Feb 8, 2023

As per https://stackoverflow.com/a/48114322, for OpenAPI 3.1 which is what we use.

@captn3m0
[api] Mark link as nullable
c8550f3 
As per https://stackoverflow.com/a/48114322, for OpenAPI 3.1
which is what we use.
@captn3m0 captn3m0 added the bug Something isn't working label Feb 8, 2023
@captn3m0 captn3m0 requested a review from marcwrobel February 8, 2023 19:51
@captn3m0 captn3m0 self-assigned this Feb 8, 2023
@captn3m0 captn3m0 mentioned this pull request Feb 8, 2023
Closed
marcwrobel
marcwrobel approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but link may not be the only nullable attribute. Should we fix all of them or just link for the time being ?

@captn3m0
Copy link
Member Author

captn3m0 commented Feb 9, 2023

Just link for the time being is fine. We have to do a schema overhaul for v1, will tackle the rest then.

@captn3m0 captn3m0 merged commit f3e394b into master Feb 9, 2023
@captn3m0 captn3m0 deleted the link-nullable branch February 9, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcwrobel marcwrobel marcwrobel approved these changes

Assignees

@captn3m0 captn3m0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captn3m0 @marcwrobel