-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Kubernetes Engine #314
Conversation
Automation NotesSince GKE releases are quite frequent, it is very hard to keep the GKE has a Get Server Config API which returns the data gke.json.zip However, the API needs authentication, so I've created a service account with zero permissions. There's 2 new scripts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the details and all is okay. The icon does not render and gives a 404 on the image. Please check...
Better for SEO, and the shortlink redirects
The _data/gke.yml file contains placeholder data _data/gke.json file is generated by this script at build-time This contains the same data that we need, and in JSON format. Jekyll prioritizes the gke.json file, and the _includes/gke.html file now references the new data accordingly. All together, it looks like: gke.md --includes--> gke.html gke.html references site.data.gke which comes from either of: - gke.yml - gke.json This file is saved in the _data directory
- The gke rake script now generates a ready version for Jekyll - This avoids weird JSON processing and sorting in Liquid
Forgot to rebase against master (icon_slug changed to iconSlug there). Should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now, nice work -> merge
I'm still unsure about the activeSupport dates, documented the policy we've been using so far, based on what was used when the page was created in #314. I think a better (and more correct) approach would be to check against the corresponding k8s release activesupport dates. It's quite unlikely that GKE gets any new features in a branch after k8s upstream stops adding them.
I'm still unsure about the activeSupport dates, documented the policy we've been using so far, based on what was used when the page was created in #314. I think a better (and more correct) approach would be to check against the corresponding k8s release activesupport dates. It's quite unlikely that GKE gets any new features in a branch after k8s upstream stops adding them.
I'd thought this would be easy, but damn Google makes this confusing
Important considerations:
Note that there are no EoL dates or active support dates for release channels since they will always be supported. Static releases do have a "release date" (when the version was made available in static), but I had to remove it to keep it consistent.
Preview: https://deploy-preview-314--endoflife-date.netlify.app/gke
Pages consulted: