-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Debian API URLs #757
Fix Debian API URLs #757
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines. If you are working on site internals, see https://github.com/endoflife-date/endoflife.date/blob/master/HACKING.md |
But the current solution has to drop the release names (buster/wheezy) from the text, which are important for Debian. Okay with merging in the intermediate, while we can look for solutions. Suggestion: How about a So for Debian, it could look like |
Will wait for a while before merging, in case there are other suggestions since this is a breaking change, but LGTM. Thanks a lot for your contribution 💯! |
The template would be a good solution here. The LTS field with a date would be perfect. 👍 |
are we sure to remove code names ? if it is we also need to make it all ( ubuntu , android , .... ) and it will also lower our visitors from search engines which generally people are searching their code names |
See the template plan above, so we'll have it back quickly. |
@captn3m0 |
Congrats on merging your first pull request! |
#891 is up with initial tempting support to fix these issues. It doesn't work for complicated cases, but the majority is easily covered. |
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> ** Why We want to make sure that our "release cycle" field is as clean as possible, since it is used in the API. Using anything that is not guessable makes it harder. However, removing descriptive information from pages (like how we did with Debian in #757) to make the API cleaner isn't a long-term solution. ** What This PR lets us keep `releaseCycle` clean, while providing 2 new attributes: `releaseLabel` and `LTSLabel` that decide how the release name will be rendered. `LTSLabel` is set for the page. `releaseLabel` is set for the page, but can be overridden on a per-release basis. This also adds a new `codename` attribute, so we can stop abusing `cycleShortHand` like we were till now. It is also available in the `changelogTemplate` (see `/ros` for eg). - Closes #653 - Closes #884 ** TODO - [x] Update contribution documentation ** Previews I updated most of the pages where it made sense to use a release label. There are lots more where it gets more complicated, so I haven't attempted those yet. Here's links for the impacted pages to easily review the relevant pages:
I would like to make a couple of suggestions.
I want to use the API. The issue here is that the URL is very inconvenient as the path needs to be urlencoded and is generated from the
releaseCycle
field. Example:Something like this would be much easier to work with:
This means also that you can already understand how the API works, even if you dont know much details about your requesting product. At the moment you have to request the product, urlencode the releaseCycle and generate a new request.
My shorter path would be usable even if you don't know the current release tag. urlencoding is probbaly not a problem with JavaScript. But doing this on a shell is a nightmare. So I split the fields and introduced
cycleShortHand
for Debian.Debian 9 is in LTS now. So I removed the 2nd Debian 9 block. But there is also something to discuss. Its not true that there is a non-LTS and a LTS version of a release at the same time. The LTS starts when the support for a release is dropped by the Debian Security Team. The Question is how to handle this? Just add a LTS flag at the end of the official support? Should be EOL date the point when official support is dropped? Or when the LTS is dropped?
An other way could be to add releases like
9-LTS
. This is "released" when the official support is dropped.Here is also another idea for this: #156
Here was this also a topic: #456 I have checked it and there is no need to change something on the system to get LTS support. The apt sources are the same as for the regular stable release.
I have added a some other changes:
cat /etc/os-release
contains more and better information thanlsb_release
. I have also added the latest version of 6 and 7. also some typos.Some of my points also hit other products like Ubuntu.