fix(exo): review suggestions

endojs · Dec 21, 2023 · bf29a3a · bf29a3a
1 parent b645649
commit bf29a3a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 20 deletions.
diff --git a/packages/exo/test/test-amplify-heap-class-kits.js b/packages/exo/test/test-amplify-heap-class-kits.js
@@ -8,21 +8,14 @@ import { M } from '@endo/patterns';
 import { defineExoClass, defineExoClassKit } from '../src/exo-makers.js';
 
 const UpCounterI = M.interface('UpCounter', {
-  incr: M.call()
-    // TODO M.number() should not be needed to get a better error message
-    .optional(M.and(M.number(), M.gte(0)))
-    .returns(M.number()),
+  incr: M.call().optional(M.gte(0)).returns(M.number()),
 });
 
 const DownCounterI = M.interface('DownCounter', {
-  decr: M.call()
-    // TODO M.number() should not be needed to get a better error message
-    .optional(M.and(M.number(), M.gte(0)))
-    .returns(M.number()),
+  decr: M.call().optional(M.gte(0)).returns(M.number()),
 });
 
 test('test amplify defineExoClass fails', t => {
-  // let amp;
   t.throws(
     () =>
       defineExoClass(
@@ -38,9 +31,7 @@ test('test amplify defineExoClass fails', t => {
           },
         },
         {
-          receiveAmplifier(a) {
-            // amp = a;
-          },
+          receiveAmplifier(_) {},
         },
       ),
     {

diff --git a/packages/exo/test/test-revoke-heap-classes.js b/packages/exo/test/test-revoke-heap-classes.js
@@ -8,17 +8,11 @@ import { defineExoClass, defineExoClassKit } from '../src/exo-makers.js';
 const { apply } = Reflect;
 
 const UpCounterI = M.interface('UpCounter', {
-  incr: M.call()
-    // TODO M.number() should not be needed to get a better error message
-    .optional(M.and(M.number(), M.gte(0)))
-    .returns(M.number()),
+  incr: M.call().optional(M.gte(0)).returns(M.number()),
 });
 
 const DownCounterI = M.interface('DownCounter', {
-  decr: M.call()
-    // TODO M.number() should not be needed to get a better error message
-    .optional(M.and(M.number(), M.gte(0)))
-    .returns(M.number()),
+  decr: M.call().optional(M.gte(0)).returns(M.number()),
 });
 
 test('test revoke defineExoClass', t => {