Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message improvement causes agoric-sdk golden test failure #1640

Closed
erights opened this issue Jun 15, 2023 · 3 comments
Closed

Error message improvement causes agoric-sdk golden test failure #1640

erights opened this issue Jun 15, 2023 · 3 comments
Assignees
@erights

Comments

@erights
Copy link
Contributor

erights commented Jun 15, 2023

#1606 improved at least one error message, which is great. However, some tests in current agoric-sdk currently depend on the old error message.
@erights erights self-assigned this Jun 15, 2023
@erights erights mentioned this issue Jun 15, 2023
Closed
@erights
Copy link
Contributor Author

erights commented Jun 15, 2023

Example at https://github.com/Agoric/agoric-sdk/actions/runs/5273958254/jobs/9538040586?pr=7926#step:8:23

@erights
Copy link
Contributor Author

erights commented Jun 15, 2023

Used Agoric/agoric-sdk#7926 to detect such problems

@gibson042 gibson042 mentioned this issue Jun 15, 2023
Closed
@erights
Copy link
Contributor Author

erights commented Jun 23, 2023

Closing as a duplicate of Agoric/agoric-sdk#7931 which was already closed by Agoric/agoric-sdk#7932

@erights erights closed this as completed Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erights erights

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(patterns): revert error msg improvement that breaks old tests endojs/endo
1 participant
@erights