Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(patterns): revert error msg improvement that breaks old tests #1638

Closed
wants to merge 1 commit into from

Conversation

erights
Copy link
Contributor

@erights erights commented Jun 15, 2023

Fixes #1640

#1606 improved at least one error message, which is great. However, some tests in current agoric-sdk currently depend on the old error message, which this PR restores.

Note that this PR restores the message, but not by reverting to the code before #1606. Rather, it continues to use the mechanisms introduced in #1606 to output the earlier message.

TODO: Upgrade the tests in agoric-sdk that depend on the old message to also tolerate the improvement.

@erights
Copy link
Contributor Author

erights commented Jun 15, 2023

@gibson042
Copy link
Contributor

Ugh, I was hoping not to see such tests outside of endo. But fortunately, there didn't seem to be many of them—alternative PR that loosens the error message assertions within agoric-sdk is now up at Agoric/agoric-sdk#7932 .

@erights
Copy link
Contributor Author

erights commented Jun 15, 2023

Closing in favor of Agoric/agoric-sdk#7932

@erights erights closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message improvement causes agoric-sdk golden test failure
2 participants