Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(patterns): revert error msg improvement that breaks old tests #1638

Closed
wants to merge 1 commit into from
Closed

test(patterns): revert error msg improvement that breaks old tests #1638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/patterns/src/patterns/patternMatchers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,8 +953,19 @@ const makePatternKit = () => {
false,
// `label` can be embedded without quotes because it is provided by
// local code like `M.remotable("...")`.
X`${specimen} - Must be a remotable ${b(label)}, not ${kindDetails}`,
X`${kindDetails} ${specimen} - Must be a remotable (${b(label)})`,
);
// We would like to use the commented out code below rather than the
// the similar code immediately above. The new code improves the error
// message, which is great. However, currently agoric-sdk has tests that
// depend on the error message emitted by the code above.
// TODO use the code below when we can.
//
// return check(
// false,
// // `label` can be embedded without quotes because it is provided by
// // local code like `M.remotable("...")`.
// X`${specimen} - Must be a remotable ${b(label)}, not ${kindDetails}`,
},

checkIsWellFormed: (allegedRemotableDesc, check) =>
Expand Down