Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop matrix from the lint job #2283

Closed
turadg opened this issue May 13, 2024 · 0 comments · Fixed by #2477
Closed

drop matrix from the lint job #2283

turadg opened this issue May 13, 2024 · 0 comments · Fixed by #2477
Labels
enhancement New feature or request

Comments

@turadg
Copy link
Member

turadg commented May 13, 2024

What is the Problem Being Solved?

The lint job does static analysis, but it's configured to run against multiple Node runtimes. Only one is needed and it shouldn't have a matrix because that necessitates updating its Required check when bumping Node versions.

Description of the Design

  1. Take the matrix out of

    endo/.github/workflows/ci.yml

    Lines 18 to 28 in b02f0e2

    name: lint
    # begin macro
    runs-on: ${{ matrix.platform }}
    strategy:
    fail-fast: false
    matrix:
    node-version: [18.x, 20.x]
    platform: [ubuntu-latest]

  2. A repo admin updates settings to require the plain "lint" job, not the runtime-scoped one

Security Considerations

Scaling Considerations

Test Plan

Compatibility Considerations

Upgrade Considerations
@turadg turadg added the enhancement New feature or request label May 13, 2024
kriskowal added a commit that referenced this issue Oct 1, 2024
@kriskowal
chore(ci): Drop matrix for lint job
70d0e85 
Fixes #2283
@kriskowal kriskowal mentioned this issue Oct 1, 2024
Merged
kriskowal added a commit that referenced this issue Oct 1, 2024
@kriskowal
chore(ci): Drop matrix for lint job (#2477)
164a5a5 
Fixes #2283

In order to avoid unnecessary duplication of effort in CI and to keep
the required Lint job name consistent as we upgrade the underlying
Node.js version, this change drops the test matrix and hard-codes the
platform and node version.
@leotm leotm mentioned this issue Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): Drop matrix for lint job endojs/endo
1 participant
@turadg