fix(exo): do NOT mutate behaviorMethods argument #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-1641-do-not-mutate-behavior-argument
branch
from
df99bfa
to
343d4d0
Compare
erights
force-pushed
the
markm-1641-do-not-mutate-behavior-argument
branch
3 times, most recently
from
00c807e
to
73d1471
Compare
kriskowal
approved these changes
Jun 16, 2023
|
Aside, Goblins actors can express both function call behavior and method invocation behavior. Can an Exo class or Far reference fully emulate such a Goblins actor? |
erights
force-pushed
the
markm-1641-do-not-mutate-behavior-argument
branch
from
73d1471
to
2468362
Compare
Exo class or instance --- no. Exos do not yet support far functions.
But whether the |
erights
force-pushed
the
markm-1641-do-not-mutate-behavior-argument
branch
from
2468362
to
43f89ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1641
OMG I was mutating a passed in argument that originated from a normal program outside the package. Thus, I was inadvertently mutating that program's state that was not supposed to be mutated. When they then reused that argument in another call, they were passing in the mutated one.