feat(env-options): env-options conveniences for common cases #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2023
erights
force-pushed
the
markm-options-harmony
branch
from
dae87da
to
f6190e7
Compare
erights
force-pushed
the
markm-options-harmony
branch
3 times, most recently
from
b0abc60
to
11e8047
Compare
erights
force-pushed
the
markm-options-harmony
branch
3 times, most recently
from
c8cbe6f
to
e28ac45
Compare
|
See also nodejs/node#48890 |
erights
force-pushed
the
markm-options-harmony
branch
2 times, most recently
from
8515a62
to
d692fac
Compare
erights
force-pushed
the
markm-options-harmony
branch
2 times, most recently
from
2ce5dd0
to
a7664ac
Compare
erights
force-pushed
the
markm-options-harmony
branch
2 times, most recently
from
695c347
to
7799061
Compare
erights
force-pushed
the
markm-options-harmony
branch
from
7799061
to
77aea46
Compare
erights
force-pushed
the
markm-options-harmony
branch
from
77aea46
to
7577a77
Compare
erights
force-pushed
the
markm-options-harmony
branch
from
7577a77
to
1a0dd3e
Compare
erights
force-pushed
the
markm-options-harmony
branch
2 times, most recently
from
7383ed9
to
e1199d3
Compare
erights
force-pushed
the
markm-options-harmony
branch
from
e1199d3
to
30bd756
Compare
erights
force-pushed
the
markm-options-harmony
branch
from
30bd756
to
59b523f
Compare
erights
force-pushed
the
markm-options-harmony
branch
3 times, most recently
from
43ed48f
to
19b3465
Compare
erights
changed the title
erights
force-pushed
the
markm-options-harmony
branch
from
19b3465
to
c15595d
Compare
erights
force-pushed
the
markm-options-harmony
branch
from
c15595d
to
2f05b1a
Compare
This was referenced Jan 1, 2024
erights
force-pushed
the
markm-options-harmony
branch
from
2f05b1a
to
a8e1407
Compare
erights
force-pushed
the
markm-options-harmony
branch
2 times, most recently
from
6926eb8
to
a802aa5
Compare
erights
force-pushed
the
markm-options-harmony
branch
3 times, most recently
from
e130e8c
to
ac480ad
Compare
gibson042
approved these changes
Jan 10, 2024
erights
force-pushed
the
markm-options-harmony
branch
from
ac480ad
to
c2dad51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: Agoric/agoric-sdk#8136
refs: Agoric/agoric-sdk#8096
refs: https://github.com/Agoric/agoric-sdk/blob/master/docs/env.md#DEBUG
refs: #1922
The indirection of
getEnvironmentCaptoris only needed to supportgetCapturedEnvironmentOptionNamesgetCapturedEnvironmentOptionNamesis not currently used in eitherendooragoric-sdk. Thus, we have enhanced@endo/env/optionsto also directly export non-capturing forms of the other functions, likegetEnvironmentOption, that are made and returned bygetEnvironmentCaptor.The value of an option is often supposed to be a list of strings separated by commas (
','). HoweverAgoric/agoric-sdk#8096 explains that sometimes our code (both in endo and in agoric-sdk) accidentally split on colon (
':') instead due to confusion about what the convention was supposed to be.So that this PR would only be a compat
featPR, this PR does not fix any of those legacy manual uses that got the convention wrong. (Though it does add a TODO that links to Agoric/agoric-sdk#8096.) Rather,this PR does provide additional conveniences,
getEnvironmentOptionsListandenvironmentOptionsListHasbased on the correct comma option.Later PRs (#1922) that do take the compat hit of switching to comma should also switch to using these new conveniences.