test(common): migrate missing tests #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-migrate-missing-common-tests
branch
from
481cb68
to
6b183c9
Compare
erights
force-pushed
the
markm-migrate-missing-common-tests
branch
3 times, most recently
from
6f3e039
to
f6b4b2f
Compare
erights
force-pushed
the
markm-migrate-missing-common-tests
branch
from
f6b4b2f
to
5295f7f
Compare
kriskowal
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: Agoric/agoric-sdk#8771
Description
Agoric/agoric-sdk#8771 will remove some copies of code in agoric-sdk that have migrated to endo. For two of these, the corresponding tests in agoric-sdk did some minor testing beyond the corresponding tests in endo. This PR merely moves that testing logic so it doesn't get lost in the shuffle.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations