Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: temporarily allow Node.js 16 #2040

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

michaelfig
Copy link
Member

Description

Temporarily fixate on ts-api-utils@1.0.x not to force downstream simultaneous mass migration from Node.js 16. Those users can take migration into their own hands, rather than being a breaking change.

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Compatibility Considerations

Upgrade Considerations

  • Includes *BREAKING*: in the commit message with migration instructions for any breaking change.
  • Updates NEWS.md for user-facing changes.

Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐤, How does this fix work mechanically? I think this is narrowing the range of eligible versions (from the broader constraints mentioned in some transitive dependency)

@mhofman
Copy link
Contributor

mhofman commented Feb 8, 2024

I think this would only work for the endo repo, right? The top level package.json and the yarn.lock has no influence on the repos consuming endo packages.

@michaelfig
Copy link
Member Author

I think this would only work for the endo repo, right? The top level package.json and the yarn.lock has no influence on the repos consuming endo packages.

It's the @typescript-eslint devDependencies pulling in ts-api-utils, so if Node.js 16 is used to run yarn in Endo (as it is in the breaking dapp integration tests), it fails without these changes.

But you're right; I've just now pinned the versions in eslint-plugin, stream-node and stream, which also had references to @typescript-eslint.

@michaelfig
Copy link
Member Author

🐤, How does this fix work mechanically? I think this is narrowing the range of eligible versions (from the broader constraints mentioned in some transitive dependency)

That's exactly what it's doing. If the transitive dependencies change their accepted version range to reject 1.0.x, this engine restriction will happen again. I'm just buying a little time until then.

@michaelfig michaelfig merged commit b463c57 into master Feb 8, 2024
14 checks passed
@michaelfig michaelfig deleted the mfig-allow-node-16 branch February 8, 2024 17:13
@turadg turadg mentioned this pull request Sep 23, 2024
turadg added a commit that referenced this pull request Sep 23, 2024
hygiene

## Description

`ts-api-utils` was pinned to save consumers from upgrading to Node 16. 
- #2040

It's been long enough that we can drop that concession.

### Security Considerations

none
### Scaling Considerations

none

### Documentation Considerations

none

### Testing Considerations

none

### Compatibility Considerations

Endo devDependencies now really requires Node 16.

### Upgrade Considerations

TMK does not yet affect exports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants