Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore Agoric SDK compatibility for sync #2159

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

kriskowal
Copy link
Member

Two changes are necessary to close the gap with Agoric SDK.

  1. We need to use peerDependencies between @endo/ses-ava and ava, in order to allow Agoric SDK to run behind on Ava 5 while Endo is on Ava 6. This is consistent with the usage pattern of wrapTest, requiring the dependent package to combine their ava with @endo/ses-ava, with some liberty to use either version.
  2. My proposed changes for the bundleSource type signature are not currently reconciled and will have to endure another attempt.

@kriskowal kriskowal force-pushed the kriskowal-revert-bundle-source-types branch from 417f688 to a1a3c3a Compare March 19, 2024 00:08
@kriskowal kriskowal requested a review from turadg March 19, 2024 00:12
@kriskowal kriskowal merged commit 4fa8662 into master Mar 19, 2024
18 checks passed
@kriskowal kriskowal deleted the kriskowal-revert-bundle-source-types branch March 19, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants