Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ses): redefine SharedSymbol to bypass Hermes prototype bug on obj literal short-hand methods #2206

Merged
merged 7 commits into from
May 7, 2024
Merged

feat(ses): redefine SharedSymbol to bypass Hermes prototype bug on obj literal short-hand methods #2206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
91fbaa9
feat(ses): tolerate non-configurable Symbol props
leotm Apr 10, 2024
8f260a6
Revert "feat(ses): tolerate non-configurable Symbol props"
leotm Apr 15, 2024
5d4e052
fixup! feat(ses): add functionBind definition in commons.js
leotm Apr 15, 2024
6c4827a
fixup! feat(ses): redefine SharedSymbol using functionBind
leotm Apr 15, 2024
1079bdc
fixup! feat(ses): add comment
leotm Apr 15, 2024
f74eee9
fixup! feat(ses): update comment
leotm Apr 15, 2024
fd9d473
Merge branch 'master' into tolerate-non-configurable-symbol-props
mhofman May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/ses/src/commons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ export const weaksetAdd = uncurryThis(weaksetPrototype.add);
export const weaksetHas = uncurryThis(weaksetPrototype.has);
//
export const functionToString = uncurryThis(functionPrototype.toString);
export const functionBind = uncurryThis(bind);
//
const { all } = Promise;
export const promiseAll = promises => apply(all, Promise, [promises]);
Expand Down
9 changes: 4 additions & 5 deletions packages/ses/src/tame-symbol-constructor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
getOwnPropertyDescriptors,
defineProperties,
arrayMap,
functionBind,
} from './commons.js';

/**
Expand Down Expand Up @@ -37,11 +38,9 @@ export const tameSymbolConstructor = () => {
const OriginalSymbol = Symbol;
const SymbolPrototype = OriginalSymbol.prototype;

const SharedSymbol = {
Symbol(description) {
return OriginalSymbol(description);
},
}.Symbol;
// Bypass Hermes bug, fixed in: https://github.com/facebook/hermes/commit/00f18c89c720e1c34592bb85a1a8d311e6e99599
// Make a "copy" of the primordial [Symbol "constructor"](https://tc39.es/ecma262/#sec-symbol-description) which maintains all observable behavior. The primordial explicitly throws on `[[Construct]]` and has a `[[Call]]` which ignores the receiver. Binding also maintains the `toString` source as a native function. The `name` is restored below when copying own properties.
const SharedSymbol = functionBind(Symbol, undefined);

defineProperties(SymbolPrototype, {
constructor: {
Expand Down
Loading