Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release #2272

Merged
merged 5 commits into from
May 7, 2024
Merged

chore: release #2272

merged 5 commits into from
May 7, 2024

Conversation

kriskowal
Copy link
Member

@kriskowal kriskowal commented May 6, 2024

Regularly occurring releases. This include changes to pass-style, patterns, & exo including a new TypeScript type for Passables.

@kriskowal kriskowal requested a review from erights May 6, 2024 22:32
@erights
Copy link
Contributor

erights commented May 6, 2024

Regularly occurring releases. This include changes to pass-style, patterns, & exo including a new TypeScript type for Patterns.

Did you mean Passables?


### Features

* **types:** fromCapData is Passable, but unknown is more practical ([5fa54f0](https://github.com/endojs/endo/commit/5fa54f0287b467d3d6baf354a36263a4aa36ec55))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **types:** fromCapData is Passable, but unknown is more practical ([5fa54f0](https://github.com/endojs/endo/commit/5fa54f0287b467d3d6baf354a36263a4aa36ec55))
* **types:** `fromCapData` is `Passable`, but `unknown` is more practical ([5fa54f0](https://github.com/endojs/endo/commit/5fa54f0287b467d3d6baf354a36263a4aa36ec55))

If you think it is worth it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking, I see only

/**
* @template Slot
* @callback FromCapData
* @param {CapData<Slot>} data
* @returns {any} a Passable
*/
which says any, not unknown. Did you mean any?

packages/exo/CHANGELOG.md Show resolved Hide resolved
### Features

* **pass-style,exo:** exo boundary only throws throwables ([#2266](https://github.com/endojs/endo/issues/2266)) ([2f0888e](https://github.com/endojs/endo/commit/2f0888e789edca35de86fa9726e6bbd70af8be2f)), closes [#2223](https://github.com/endojs/endo/issues/2223)
* **types:** Guard is a RemotableObject ([e2bfb54](https://github.com/endojs/endo/commit/e2bfb544761143d49aa4d0040bdd2e6d6570a295))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Guard? We have interface guards, method guards, and a few others. I don't see that we have any common Guard type. Did you mean Guarded?


### Features

* **types:** fromCapData is Passable, but unknown is more practical ([5fa54f0](https://github.com/endojs/endo/commit/5fa54f0287b467d3d6baf354a36263a4aa36ec55))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a use of unknown for fromCapData.

packages/ses/NEWS.md Show resolved Hide resolved
packages/ses/CHANGELOG.md Show resolved Hide resolved
packages/ses/CHANGELOG.md Show resolved Hide resolved
@erights erights self-requested a review May 6, 2024 23:31
Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on verbal conversation. CHANGELOGs to be fixed later

 - @endo/base64@1.0.5
 - @endo/bundle-source@3.2.3
 - @endo/captp@4.2.0
 - @endo/check-bundle@1.0.7
 - @endo/cjs-module-analyzer@1.0.5
 - @endo/cli@2.2.0
 - @endo/common@1.2.2
 - @endo/compartment-mapper@1.1.5
 - @endo/daemon@2.3.0
 - @endo/env-options@1.1.4
 - @endo/errors@1.2.2
 - @endo/eslint-plugin@2.1.3
 - @endo/evasive-transform@1.1.2
 - @endo/eventual-send@1.2.2
 - @endo/exo@1.5.0
 - @endo/far@1.1.2
 - @endo/import-bundle@1.1.2
 - @endo/init@1.1.2
 - @endo/lockdown@1.0.7
 - @endo/lp32@1.1.2
 - @endo/marshal@1.5.0
 - @endo/memoize@1.1.2
 - @endo/nat@5.0.7
 - @endo/netstring@1.0.7
 - @endo/pass-style@1.4.0
 - @endo/patterns@1.4.0
 - @endo/promise-kit@1.1.2
 - @endo/ses-ava@1.2.2
 - ses@1.5.0
 - @endo/skel@1.1.2
 - @endo/static-module-record@1.1.2
 - @endo/stream-node@1.1.2
 - @endo/stream-types-test@1.0.7
 - @endo/stream@1.2.2
 - @endo/syrup@1.0.5
 - @endo/test262-runner@0.1.37
 - @endo/where@1.0.5
 - @endo/zip@1.0.5
@kriskowal kriskowal force-pushed the release-2024-05-06-22-16-41 branch from 46e3565 to f3592b6 Compare May 7, 2024 20:39
@kriskowal kriskowal enabled auto-merge May 7, 2024 20:45
@kriskowal kriskowal merged commit 1bcc769 into master May 7, 2024
17 checks passed
@kriskowal kriskowal deleted the release-2024-05-06-22-16-41 branch May 7, 2024 20:47
mergify bot added a commit to Agoric/agoric-sdk that referenced this pull request May 8, 2024
This brings Agoric in sync with Endo versions
endojs/endo#2272 which covers a new `Passable`
type and improvements to `pass-style`, `patterns`, and `exo`. This
subsumes changes from #8774
necessary for integration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants