Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ses): Shim compatible with Hermes compiler #2334
base: master
Are you sure you want to change the base?
feat(ses): Shim compatible with Hermes compiler #2334
Changes from 101 commits
f5848ef
ef479f2
eb55777
888caa9
13c72e5
7bff3fc
9578cc8
4857978
644db02
1bd528f
a87fbb8
6b6ee3b
0e8de23
94ac76b
f18e876
17ff216
d32b262
50780cb
a5ff96b
2066510
b674db0
1c52786
f66bf78
a017db0
e40555c
8c9031a
0ecf0b8
4b1b5e6
2c76a2b
a5aedbe
6c1b445
375c01b
bb2c2c8
61123b1
d373214
6909484
56a31b0
d8f35bb
61700f8
e556090
284fbdf
dc79e11
62975be
4936b6a
26921fa
528236f
b02ced1
48fd5cc
8878833
8bd257a
a6b4ff3
78ea7c9
e4f32a1
887077c
519ba25
b5f8b95
6764a40
3b6bbf1
56af377
1b968d2
85acfec
0b1ca82
984bbcf
b3bdf26
7c2bc13
ed958ab
76d1c37
c1b9051
27f766d
d7744b1
1fe6a56
e4af84a
1ed84e1
a6c0300
bea3ad4
35f8116
f2d6691
eb87783
23945e4
69c08ee
3df7ab2
e90d3bc
f82307a
849248f
7b4ef2b
7349278
ebb88c1
d8942d2
126b437
977925e
5dc71f9
7317d10
bec0121
bec2c4d
c8e6b55
7e4f681
143bf93
58bf929
e6d5d7f
e4a4f8c
63645cf
cdd2dad
5374cfc
df5a0e8
75bc6f1
8d2a152
eb7f63a
56e4660
431bff3
af3a420
7bef992
0bff9a0
a8e6593
6e1cb49
f543b16
2dc851c
9112d45
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will fail in powershell (if it matters)
consider util.parseArgs() instead of env vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally setup dev'ing on windows again woo (winget github.cli, git.git, open.nodejs, set exec policy RemoteSigned, corepack enable 💥)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any idea why it's working for me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also not particularly windows-friendly 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nb:
test:create-hermes-bin-symlinks
removedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see your point
and others set up react native on windows too
i'll create follow-up issue, did you have a solution in mind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: conflict with #2310; this would want to be
SyncModuleTransforms
instead.also, if you're reaching in to
compartment-mapper
fromses
(which it appears creates a cyclic dependency), it seems likecompartment-mapper
(or somewhere else) might want to be where this script lives.