fix(cli): Improve number parsing #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
reviewed
Sep 18, 2024
sirtimid
force-pushed
the
sirtimid/cli-parse-number
branch
from
6efdc03
to
26a8fd4
Compare
kriskowal
reviewed
Sep 19, 2024
sirtimid
force-pushed
the
sirtimid/cli-parse-number
branch
2 times, most recently
from
3b4a975
to
4c026c5
Compare
gibson042
approved these changes
Sep 25, 2024
sirtimid
force-pushed
the
sirtimid/cli-parse-number
branch
from
4c026c5
to
aa48722
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
parseNumberfunction that safely parses input as a number on cli commands.Additional tests have been added to ensure this new functionality works correctly.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
none
Compatibility Considerations
none
Upgrade Considerations
none