-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simpler test glob #2456
simpler test glob #2456
Conversation
f20b0d6
to
0be7772
Compare
e99cf04
to
ca65f92
Compare
3132501
to
094c5a1
Compare
the automated tool didn't update these paths
094c5a1
to
e68a24e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love kicking off the legacy test path pattern. Head’s up to @boneskull with possibly-impacted work in flight.
"lint-fix": "lerna run --no-bail lint-fix", | ||
"test": "lerna run --ignore @endo/skel test", | ||
"test": "lerna run --ignore @endo/skel --no-bail test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--no-opportunity-for-parole
some weird behavior around seeing this on lerna with
without
CI job https://github.com/endojs/endo/actions/runs/11153456684/job/31000992316?pr=2564 doc https://github.com/lerna/lerna/tree/main/libs/commands/run#--no-bail |
|
Closes: #1913
Description
This set out to use the Ava default file glob (i.e. no custom setting) but ultimately doesn't for two reasons:
foo.fixture.js
. We like the.test.js
consistencySince I did move a bunch of files to use underscores, I left that change in here, along with the script that does it. I have no qualms about removing them at reviewer request.
This also includes a little CI change that saved me time, ci: no-bail so all packages run lint
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
Consistent with existing practices. There is a lot of underscore now, but it's not required.
Testing Considerations
CI
Compatibility Considerations
Not exported
Upgrade Considerations
none