Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simpler test glob #2456

Merged
merged 8 commits into from
Sep 20, 2024
Merged

simpler test glob #2456

merged 8 commits into from
Sep 20, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Sep 16, 2024

Closes: #1913

Description

This set out to use the Ava default file glob (i.e. no custom setting) but ultimately doesn't for two reasons:

  • requires all the non-test files to have a preceding underscore (this is both laborious to complete and not a unanimously well received outcome)
  • would allow test files to have any file name, including foo.fixture.js. We like the .test.js consistency

Since I did move a bunch of files to use underscores, I left that change in here, along with the script that does it. I have no qualms about removing them at reviewer request.

This also includes a little CI change that saved me time, ci: no-bail so all packages run lint

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

Consistent with existing practices. There is a lot of underscore now, but it's not required.

Testing Considerations

CI

Compatibility Considerations

Not exported

Upgrade Considerations

none

@turadg turadg force-pushed the 1913-single-test-glob branch 4 times, most recently from f20b0d6 to 0be7772 Compare September 19, 2024 22:57
@turadg turadg force-pushed the 1913-single-test-glob branch 3 times, most recently from e99cf04 to ca65f92 Compare September 19, 2024 23:26
@turadg turadg marked this pull request as ready for review September 19, 2024 23:26
@turadg turadg changed the title default Ava files glob simpler test glob Sep 20, 2024
@turadg turadg force-pushed the 1913-single-test-glob branch 2 times, most recently from 3132501 to 094c5a1 Compare September 20, 2024 16:25
Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love kicking off the legacy test path pattern. Head’s up to @boneskull with possibly-impacted work in flight.

"lint-fix": "lerna run --no-bail lint-fix",
"test": "lerna run --ignore @endo/skel test",
"test": "lerna run --ignore @endo/skel --no-bail test",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--no-opportunity-for-parole

@turadg turadg merged commit c101168 into master Sep 20, 2024
15 checks passed
@turadg turadg deleted the 1913-single-test-glob branch September 20, 2024 17:09
@kumavis
Copy link
Member

kumavis commented Oct 3, 2024

some weird behavior around --no-bail

seeing this on lerna 8.1.8

with --no-bail:

lerna ERR! Received non-zero exit code 1 during execution
lerna success run Ran npm script 'test' in 39 packages in 42.6s:
lerna success - @endo/base64
lerna success - @endo/bundle-source
[...]
lerna success - ses
[...]

without --no-bail:

lerna ERR! yarn run test exited 1 in 'ses'

CI job https://github.com/endojs/endo/actions/runs/11153456684/job/31000992316?pr=2564

doc https://github.com/lerna/lerna/tree/main/libs/commands/run#--no-bail
note on inconsistency of default behavior? lerna/lerna#3827

@kumavis
Copy link
Member

kumavis commented Oct 3, 2024

yarn workspaces foreach runs all without bailing #2565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adopt Ava default files glob
3 participants