test: Introduce XS CI workflow #2465
Open
+80
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
kriskowal-xs-ci
branch
12 times, most recently
from
a21437e
to
713abb1
Compare
kriskowal
force-pushed
the
kriskowal-xs-ci
branch
4 times, most recently
from
004dd04
to
061240f
Compare
mhofman
reviewed
Sep 21, 2024
.github/workflows/ci.yml
Outdated
| - name: Run yarn build | ||
| run: yarn build | ||
|
|
||
| - name: Get XS |
There was a problem hiding this comment.
Here's an idea:
Suggested change
| - name: Get XS | |
| - name: Check release | |
| id: check-release | |
| run: | | |
| if curl -f -s -o /dev/null -I -L https://api.github.com/repos/Moddable-OpenSource/moddable/releases/tags/${{ matrix.moddable-version }} then | |
| echo "release=true" | |
| else | |
| echo "release=false" | |
| fi >> $GITHUB_OUTPUT | |
| - name: Get XS | |
| if: steps.check-release.outputs.release == 'true' |
With the build step if it's not.
mhofman
reviewed
Sep 21, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
350
to
351
| # - name: Clone XS | ||
| # run: git clone https://github.com/moddable-OpenSource/moddable --branch "${{ matrix.moddable-version }}" --depth 1 |
There was a problem hiding this comment.
I'd recommend using actions/checkout, also avoid to checkout as a subfolder of the repo under testing, it tends to complicate things
26 tasks
kriskowal
force-pushed
the
kriskowal-xs-ci
branch
3 times, most recently
from
dd0216b
to
2ed5693
Compare
kriskowal
force-pushed
the
kriskowal-xs-ci
branch
from
2ed5693
to
51b25fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #2254
Description
Rigs CI to run tests with
xst. We can elaborate on this with a broader XS version vector and add XS tests to packages. This is in anticipation of a new harness262 package that will needxstin CI.