Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Lint/Test/Test262 workflow #37

Merged
merged 24 commits into from
Feb 20, 2020
Merged

CI Lint/Test/Test262 workflow #37

merged 24 commits into from
Feb 20, 2020

Conversation

jfparadis
Copy link
Contributor

@jfparadis jfparadis commented Feb 14, 2020

This is a different approach to:
#15

It resolves this issues:

  • Use Lerna to avoid the need to order the manually workspaces at the top level.
  • Use Lerna to also use the same tool as the developer would use.
  • Remove the no-bail option.
  • Provide individual job results in the PR checks (lint, test, test262)
  • Reduce the verbosity of test output (different reporter)
  • Simplify test dependencies in compartment-shim

@jfparadis jfparadis changed the title Test workflow CI Lint/Test/Test262 workflow Feb 20, 2020
@jfparadis jfparadis requested a review from warner February 20, 2020 21:25
Copy link
Contributor

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks just fine. Go for it!

For agoric-sdk, I'm still kinda interested in breaking out the individual package test results in the Actions display (i.e. testing each in a different step). I have an idea about how to deal with the maintenance overhead of that (Agoric/agoric-sdk#579) but I haven't had the time to try and implement it yet. When all tests pass, it doesn't matter much.

I'd say land this and then I'll keep my eyes open for later PR results, and I'll look to see how much work it takes to find a failure in the Actions results. Maybe it's pretty easy, and I shouldn't put much energy into splitting the packages out to separate lines.

@jfparadis jfparadis merged commit 598ef41 into master Feb 20, 2020
@jfparadis
Copy link
Contributor Author

I've made everything fail fast, so it's always the last line of a job. Example:
https://github.com/Agoric/SES-beta/runs/458829297?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants