-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Lint/Test/Test262 workflow #37
Conversation
c79502a
to
923b393
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks just fine. Go for it!
For agoric-sdk, I'm still kinda interested in breaking out the individual package test results in the Actions display (i.e. testing each in a different step). I have an idea about how to deal with the maintenance overhead of that (Agoric/agoric-sdk#579) but I haven't had the time to try and implement it yet. When all tests pass, it doesn't matter much.
I'd say land this and then I'll keep my eyes open for later PR results, and I'll look to see how much work it takes to find a failure in the Actions results. Maybe it's pretty easy, and I shouldn't put much energy into splitting the packages out to separate lines.
I've made everything fail fast, so it's always the last line of a job. Example: |
This is a different approach to:
#15
It resolves this issues:
no-bail
option.compartment-shim