-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(endo): Add command line #398
Conversation
@michaelfig recommended reserving |
de73aa0
to
d5b4a2f
Compare
0cebbf5
to
c85bc45
Compare
d5b4a2f
to
b96ce4e
Compare
5576faa
to
e61b52b
Compare
dc44b5b
to
95db8a1
Compare
827fd6a
to
58a77a3
Compare
95db8a1
to
08b9e2e
Compare
58a77a3
to
d3ce297
Compare
5ad291c
to
f97cf8b
Compare
1830eba
to
c753e7f
Compare
f97cf8b
to
50aaf19
Compare
c753e7f
to
2a8ec4d
Compare
50aaf19
to
04299ff
Compare
2a8ec4d
to
fa49fa3
Compare
04299ff
to
23a0640
Compare
fa49fa3
to
7618077
Compare
23a0640
to
32d8316
Compare
7618077
to
b5fe6ce
Compare
32d8316
to
0153b14
Compare
b5fe6ce
to
9c6ec13
Compare
0153b14
to
2a9c519
Compare
9c6ec13
to
e10970c
Compare
c2ad82b
to
dfc0f63
Compare
7634bde
to
d32a609
Compare
dfc0f63
to
0cdfa64
Compare
d32a609
to
c666cb4
Compare
344f096
to
b14638e
Compare
3282d62
to
64eae5c
Compare
b14638e
to
161d964
Compare
64eae5c
to
b3a6786
Compare
161d964
to
a2ac88b
Compare
a2ac88b
to
4cee940
Compare
7abef39
to
96f990b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I could probably bikeshed on the subcommand names for a while, so I say just land it now and we'll figure out the details later.
@@ -0,0 +1 @@ | |||
endo.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does.. this work? Is there some weird pseudo-symlink data format going on here that Node.js recognizes in a bin:
property? I would have expected package.json to point at endo.js
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll point this to endo.js
since you’re right that it’s more likely to work depending on what tool you use to install CLI’s. But, Node.js does pierce symlinks such that relative imports are always relative to the canonical location.
96f990b
to
0ed3dbc
Compare
This change provides a preliminary command line for
endo
, mostly because it is convenient for ad-hoc testing, though it will likely grow into something else.Usage:
This is entirely open for discussion.