-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SBValue crash and add some features #24
base: main
Are you sure you want to change the base?
Conversation
I will look at this a little bit more, but in the meantime, I did push a quick change that adds |
Oh yes, thank you ! |
/* | ||
pub fn get_description(&self, description: SBStream) -> SBStream { | ||
} | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the implementation here. Do we create a new SBFrame and return it as an option if sys::SBMemoryRegionInfoGetDescription
returns true ? in the source code of lldb, it always returns true. Or Do we take an SBFrame in parameter and pass it in the sys function ?
I'm trying to implement pub fn read_memory(&self, addr: u64, size: usize) -> Result<(usize, Vec<u8>), SBError> {
let error = SBError::default();
let mut vec: Vec<u8> = Vec::with_capacity(size);
let ret = unsafe {
sys::SBProcessReadMemory(
self.raw,
addr,
vec.as_mut_ptr() as *mut c_void,
size,
error.raw,
)
};
// I check if error is success, etc. Do you have an idea about the implementation ? |
I'm really sorry. I left on an international trip in June for almost a month, got sick, and then got distracted and forgot about this. I'll cherry pick more from here over the next couple of days. |
Hey @waywardmonkeys @tetenpapier p.s. i find it kinda funny that we can disable, enable and delete breakpoints, but there is no way to create them... |
@Casilio I think it's better to cherrypick some commits because this PR has now conflicts and I don't have time now to resolve them :/ maybe in 2/3 weeks, if I remember. |
If I don't push anything in the next 24 hours, please ping me here again. I've got a couple of things going on, but I think I can make some progress here today. |
Hi, I'm also experiencing a |
I fix the bug found in #23 and add some methods to create breakpoints, check child of SBValue and change the value of SBValue. I'll continue to add some functions in the future.