Modernize code base

src/Controller/TeamCalendarController.php

@@ -15,11 +15,11 @@
 final class TeamCalendarController
 {
     public function __construct(
-        private CompetitionLoaderInterface $competitionLoader,
-        private TeamLoaderInterface $teamLoader,
-        private GameLoaderInterface $gameLoader,
-        private CalendarFactory $calendarFactory,
-        private IcalWriter $calendarWriter
+        private readonly CompetitionLoaderInterface $competitionLoader,
+        private readonly TeamLoaderInterface $teamLoader,
+        private readonly GameLoaderInterface $gameLoader,
+        private readonly CalendarFactory $calendarFactory,
+        private readonly IcalWriter $calendarWriter
     ) {
     }
 

src/Controller/TeamListController.php

@@ -14,10 +14,10 @@ final class TeamListController
 {
     public function __construct(
         /** @var array<string> */
-        private array $competitionNames,
-        private Environment $templating,
-        private CompetitionLoaderInterface $competitionLoader,
-        private TeamLoaderInterface $teamLoader
+        private readonly array $competitionNames,
+        private readonly Environment $templating,
+        private readonly CompetitionLoaderInterface $competitionLoader,
+        private readonly TeamLoaderInterface $teamLoader
     ) {
     }
 

src/EndroidSoccerCalendarBundle.php

@@ -6,6 +6,6 @@
 
 use Symfony\Component\HttpKernel\Bundle\Bundle;
 
-class EndroidSoccerCalendarBundle extends Bundle
+final class EndroidSoccerCalendarBundle extends Bundle
 {
 }

tests/EndroidSoccerCalendarBundleTest.php

@@ -6,9 +6,9 @@
 
 use PHPUnit\Framework\TestCase;
 
-class EndroidSoccerCalendarBundleTest extends TestCase
+final class EndroidSoccerCalendarBundleTest extends TestCase
 {
-    public function testNoTestsYet()
+    public function testNoTestsYet(): void
     {
         $this->assertTrue(true);
     }