Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid refreshing undefined token #532

Merged
merged 1 commit into from
Apr 21, 2022
Merged

fix: avoid refreshing undefined token #532

merged 1 commit into from
Apr 21, 2022

Conversation

Harasz
Copy link
Contributor

@Harasz Harasz commented Apr 20, 2022 •
edited
Loading

Description

Avoid refreshing tokens when refresh token is undefined

Contributor checklist

  • Breaking changes - check for any existing interfaces changes that are not backward compatible, removed method etc.
  • Documentation - document your code, add comments for method, remember to check if auto generated docs were updated.
  • Tests - add new or updated existed test for changes you made.
  • Migration guide - add migration guide for every breaking change.
  • Configuration correctness - check that any configuration changes are correct ex. default URLs, chain ids, smart contract verification on Volta explorer or EWC explorer.

@Harasz Harasz requested review from jrhender and JGiter April 20, 2022 13:20
jrhender
jrhender approved these changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@jrhender jrhender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Harasz Harasz merged commit 9dc432c into develop Apr 21, 2022
@Harasz Harasz deleted the task/IS-39-fix-undefined-token branch April 21, 2022 12:01
@ewf-devops
Copy link

🎉 This PR is included in version 5.1.0-alpha.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ewf-devops
Copy link

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhender jrhender jrhender approved these changes

@JGiter JGiter JGiter approved these changes

Assignees
No one assigned
Labels
released on @canary released on @latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Harasz @ewf-devops @jrhender @JGiter