Skip to content

Commit

Permalink
[camera, google_sign_in, espresso] Bump guava to version 33.3.1. (f…
Browse files Browse the repository at this point in the history
…lutter#7773)

Fixes flutter/flutter#155458
Fixes flutter/flutter#154586

Bumps Guava to `33.3.1`, as from what I can tell we were essentially hitting google/guava#7397, from a [comment](google/guava#7397 (comment)) on the issue:
> I'm a little surprised that AGP wouldn't have complained already for any builds that depended on Guava classes that used those annotations, since it presumably wouldn't find the annotations on the runtime classpath.

I believe this maintainers suspicions were warranted, as it seems AGP was complaining in our case!

That issue was fixed in version `33.3.1` of Guava. Verified that I could re-create the failure in the [first issue](flutter/flutter#155458), and then verified that it was fixed with no additional proguard rules by upgrading the Guava version used by the `google_sign_in` plugin. Decided to make the upgrade everywhere we use guava, so we don't hit it in another plugin later.
  • Loading branch information
gmackall authored Oct 3, 2024
1 parent 309398a commit 429650f
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 6 deletions.
4 changes: 4 additions & 0 deletions packages/camera/camera_android_camerax/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.6.9+1

* Bumps `com.google.guava:guava` from `33.3.0` to `33.3.1`.

## 0.6.9

* Corrects assumption about automatic preview correction happening on API >= 29 to API > 29,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ dependencies {
implementation "androidx.camera:camera-camera2:${camerax_version}"
implementation "androidx.camera:camera-lifecycle:${camerax_version}"
implementation "androidx.camera:camera-video:${camerax_version}"
implementation 'com.google.guava:guava:33.3.0-android'
implementation 'com.google.guava:guava:33.3.1-android'
testImplementation 'junit:junit:4.13.2'
testImplementation 'org.mockito:mockito-inline:5.0.0'
testImplementation 'androidx.test:core:1.4.0'
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: camera_android_camerax
description: Android implementation of the camera plugin using the CameraX library.
repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.6.9
version: 0.6.9+1

environment:
sdk: ^3.5.0
Expand Down
4 changes: 4 additions & 0 deletions packages/espresso/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.4.0+2

* Bumps `com.google.guava:guava` from `31.1` to `33.3.1`.

## 0.4.0+1

* Updates lint checks to ignore NewerVersionAvailable.
Expand Down
2 changes: 1 addition & 1 deletion packages/espresso/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ android {
}

dependencies {
implementation 'com.google.guava:guava:31.1-android'
implementation 'com.google.guava:guava:33.3.1-android'
implementation 'com.squareup.okhttp3:okhttp:4.11.0'
implementation 'com.google.code.gson:gson:2.10.1'
androidTestImplementation 'org.hamcrest:hamcrest:2.2'
Expand Down
2 changes: 1 addition & 1 deletion packages/espresso/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Java classes for testing Flutter apps using Espresso.
Allows driving Flutter widgets from a native Espresso test.
repository: https://github.com/flutter/packages/tree/main/packages/espresso
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+espresso%22
version: 0.4.0+1
version: 0.4.0+2

environment:
sdk: ^3.4.0
Expand Down
4 changes: 4 additions & 0 deletions packages/google_sign_in/google_sign_in_android/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 6.1.31

* Bumps `com.google.guava:guava` from `32.0.1` to `33.3.1`.

## 6.1.30

* Temporarily downgrades Guava from version 33.3.0 to 32.0.1 to fix an R8 related error.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ android {

dependencies {
implementation 'com.google.android.gms:play-services-auth:21.0.0'
implementation 'com.google.guava:guava:32.0.1-android'
implementation 'com.google.guava:guava:33.3.1-android'
testImplementation 'junit:junit:4.13.2'
testImplementation 'org.mockito:mockito-inline:5.0.0'
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: google_sign_in_android
description: Android implementation of the google_sign_in plugin.
repository: https://github.com/flutter/packages/tree/main/packages/google_sign_in/google_sign_in_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+google_sign_in%22
version: 6.1.30
version: 6.1.31

environment:
sdk: ^3.4.0
Expand Down

0 comments on commit 429650f

Please sign in to comment.