Mark test that leaks image. (#142539)

engine-flutter-autoroll · Jan 31, 2024 · 6d8aa4a · 6d8aa4a
1 parent 50dbcc4
commit 6d8aa4a
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 1 deletion.
diff --git a/packages/flutter/test/cupertino/text_field_test.dart b/packages/flutter/test/cupertino/text_field_test.dart
@@ -626,6 +626,7 @@ void main() {
     const Color expectedSelectionHandleColor = Color.fromARGB(255, 10, 200, 255);
 
     final TextEditingController controller = TextEditingController(text: 'Some text.');
+    addTearDown(controller.dispose);
 
     await tester.pumpWidget(
       CupertinoApp(

diff --git a/packages/flutter/test/material/dropdown_menu_test.dart b/packages/flutter/test/material/dropdown_menu_test.dart
@@ -1935,6 +1935,7 @@ void main() {
 
   testWidgets('DropdownMenu.focusNode can focus text input field', (WidgetTester tester) async {
     final FocusNode focusNode = FocusNode();
+    addTearDown(focusNode.dispose);
     final ThemeData theme = ThemeData();
 
     await tester.pumpWidget(MaterialApp(

diff --git a/packages/flutter/test/material/menu_anchor_test.dart b/packages/flutter/test/material/menu_anchor_test.dart
@@ -2616,6 +2616,7 @@ void main() {
                     child: const Text('Set focus to null'),
                     onPressed: () {
                       setState((){
+                        buttonFocusNode?.dispose();
                         buttonFocusNode = null;
                       });
                     },

diff --git a/packages/flutter/test/material/text_field_test.dart b/packages/flutter/test/material/text_field_test.dart
@@ -9297,6 +9297,7 @@ void main() {
     const Color expectedSelectionHandleColor = Color.fromARGB(255, 10, 200, 255);
 
     final TextEditingController controller = TextEditingController(text: 'Some text.');
+    addTearDown(controller.dispose);
 
     await tester.pumpWidget(
       MaterialApp(

diff --git a/packages/flutter/test/widgets/scroll_aware_image_provider_test.dart b/packages/flutter/test/widgets/scroll_aware_image_provider_test.dart
@@ -167,7 +167,10 @@ void main() {
     expect(imageCache.currentSize, 1);
   });
 
-  testWidgets('ScrollAwareImageProvider delays if in scrollable that is scrolling fast', (WidgetTester tester) async {
+  testWidgets('ScrollAwareImageProvider delays if in scrollable that is scrolling fast',
+  // TODO(polina-c): make sure images are disposed, https://github.com/flutter/flutter/issues/141388  [leaks-to-clean]
+  experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
+  (WidgetTester tester) async {
     final List<GlobalKey<TestWidgetState>> keys = <GlobalKey<TestWidgetState>>[];
     final ScrollController scrollController = ScrollController();
     addTearDown(scrollController.dispose);