Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way tsd-jsdoc checks for members already declared on the parent. Instead of searching for an already existing member with the same name on any parent, it now checks if the member is actually inherited, so that explicitly overridden members (i.e. a method that has a different signature) are generated.
This might affect other projects using tsd-jsdoc, depending on how overrides are documented there. If, for example, an
@override
annotation is present, then the member will still be skipped with the PR applied, but if it is not explicitly annotated as one, the member will now be generated. This is a bit counter-intuitive but it seems to be the jsdoc-way (it discards any jsdoc on the child when it sees@override
, just like@inheritdoc
does - see)See: #9