Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft-05 interop with moq-rs (publish endpoint) (#5) #2

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

TilsonJoji
Copy link
Contributor

@TilsonJoji TilsonJoji commented Nov 7, 2024

Hello Mike @englishm ,

With this PR have attempted to add interop support for "/publish" in moq-js with the draft-05 version of moq-rs as of commit englishm/moq-rs@bf830f7

i.e. /publish (moq-js) => moq-rs <= /watch (moq-js)

At times crash was observed during decoding u8 while testing interop with draft-05 Publish endpoint of moq-js , This PR moq-rs attempts to defend it.

* draft05-moqrs-interop-with-moqjs-publishendpoint

* draft05-moqrs-interop-with-moqjs-publishendpoint-2
@TilsonJoji
Copy link
Contributor Author

UT

/publish (moq-js) => moq-rs <= /watch (moq-js) [ Webcam pointing to screen running time.is clock ]

draft-05-moqjs-publishUT.mp4

@TilsonJoji TilsonJoji marked this pull request as ready for review November 7, 2024 16:26
@englishm
Copy link
Owner

englishm commented Nov 7, 2024

Thanks!

@englishm englishm merged commit 6b99350 into englishm:main Nov 7, 2024
1 check passed
zafergurel pushed a commit to zafergurel/moq-js that referenced this pull request Jan 17, 2025
* draft05-interopsupport-with-moqrs-watchendpoint-bldfix

* draft05-interopsupport-with-moqrs-watchendpoint-bldfix2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants