Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the majority of the MoQT-v6 features listed in Implement DRAFT-06 Support!
With these changes we're able to get publishing and multi-track playback with Mike's englishm/moq-rs#8 relay/publisher running 😎
main
. Publishing without an audio track works just fine.We're not actually that far off from 07 functionality. A great deal of the 06/07 diff is explicitly adding the message lengths that are mentioned (vaguely) in 06. The big lift is FETCH. This explains why Jordi went straight from DRAFT-05 -> DRAFT-07 (minus FETCH) in this moq-encoder-player PR.
There is a lot to go through here so I recommend reviewing commit by commit. Lmk if you have any questions and don't hesitate to drop nits/feedback!
// Implemented in moq-rs/me/draft-06
0xff000006
)"/foo/bar/baz"
and this serializes as"foo/bar/baz"
for namespace comparisons/lookups.// Implemented in backend, but not in this PR
// Not yet implemented in moq-rs