Make module compatible with newer versions of React #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any comments? |
|
@rikukissa Could you rebase please? Sorry for the delay on our end. |
|
Done and done! |
|
Hmm, still says there's a merge conflict @rikukissa |
* Replace this.transferPropsTo with React.createElement - https://gist.github.com/sebmarkbage/a6e220b7097eb3c79ab7 * Replace React.DOM.input and React.DOM.textarea with strings
|
Oh! I think I failed somehow. Should be fine now :) |
|
Landed in 1e1e268, thanks for your contribution @rikukissa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works with React 0.13.1. These changes might not be backwards compatible with older versions of React so a major version change might be in place.