BP-1123: Update packages to latest version #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsljivic
approved these changes
May 22, 2024
msljivic
commented
May 22, 2024
| @@ -34,9 +34,8 @@ public static bool TryParse(Uri uri, out AzureBlobSharedUri sharedUri) | |||
|
|
|||
| private static AzureBlobSharedUri Parse(Uri uri) | |||
| { | |||
| var decodedUri = new Uri(HttpUtility.UrlDecode(uri.AbsoluteUri)); | |||
There was a problem hiding this comment.
Removed double decoding, no need to decode full URL. Only query params should be decoded which we already do.
msljivic
commented
May 22, 2024
| @@ -18,7 +18,7 @@ public void TestWriteRecords() | |||
| FirstName = "John", | |||
| LastName = "Doe", | |||
| Age = 30, | |||
| LastLogon = new DateTimeOffset(2023, 12, 19, 9, 30, 0, DateTimeOffset.Now.Offset), | |||
There was a problem hiding this comment.
DateTimeOffset.Now.Offset will produce different values depending on a daylight saving
avanwaas
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update packages to latest version.
Package 'Azure.Identity' 1.10.4 has a known moderate severity vulnerability.