Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Use objc2 instead of objc #249

Closed
pentamassiv opened this issue Nov 20, 2023 · 3 comments
Closed

macOS: Use objc2 instead of objc #249

pentamassiv opened this issue Nov 20, 2023 · 3 comments

Comments

@pentamassiv
Copy link
Collaborator

The objc seems to no longer be maintained and objc2 is a good replacement. Many larger projects already use it, as can be seen in the list of dependents.

https://crates.io/crates/objc2

@pentamassiv
Copy link
Collaborator Author

@paulora2405, maybe you can also do this while you are touching the macOS code?

@paulora2405
Copy link
Contributor

Seems easy enough to replace, will try to close this as soon as I can.

What is the proper way of validating any changes like these?

@pentamassiv
Copy link
Collaborator Author

pentamassiv commented Nov 20, 2023

If I make some bigger changes, I just manually test the various functions of the Keyboard and Mouse traits (I use and slightly change the examples for that). Theoretically there are some tests, but there are not enough and they are not written well. They use the browser to detect key presses and mouse movements. I always wanted to improve that but did not get to it yet.

For dependency updates I usually assume "If it builds, it works". Probably not ideal though.

paulora2405 added a commit to paulora2405/enigo that referenced this issue Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants