upgrade required and /graphql

enisdenjo · May 11, 2023 · 732bd49 · 732bd49
1 parent c63cd31
commit 732bd49
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/benchmark/servers/deno.ts b/benchmark/servers/deno.ts
@@ -14,7 +14,7 @@ const handler = makeHandler({ schema });
 serve(
   (req: Request) => {
     if (req.headers.get('upgrade') != 'websocket') {
-      return new Response(null, { status: 501 });
+      return new Response('Upgrade Required', { status: 426 });
     }
     const { socket, response } = Deno.upgradeWebSocket(req, {
       protocol: GRAPHQL_TRANSPORT_WS_PROTOCOL,

diff --git a/src/use/deno.ts b/src/use/deno.ts
@@ -39,8 +39,12 @@ export interface Extra {
  *
  * serve(
  *   (req: Request) => {
+ *     const [path, _search] = req.url.split('?');
+ *     if (!path.endsWith('/graphql')) {
+ *       return new Response('Not Found', { status: 404 });
+ *     }
  *     if (req.headers.get('upgrade') != 'websocket') {
- *       return new Response(null, { status: 501 });
+ *       return new Response('Upgrade Required', { status: 426 });
  *     }
  *     const { socket, response } = Deno.upgradeWebSocket(req, {
  *       protocol: GRAPHQL_TRANSPORT_WS_PROTOCOL,

diff --git a/website/src/pages/get-started.mdx b/website/src/pages/get-started.mdx
@@ -155,8 +155,12 @@ const handler = makeHandler({ schema });
 
 serve(
   (req: Request) => {
+    const [path, _search] = req.url.split('?');
+    if (!path.endsWith('/graphql')) {
+      return new Response('Not Found', { status: 404 });
+    }
     if (req.headers.get('upgrade') != 'websocket') {
-      return new Response(null, { status: 501 });
+      return new Response('Upgrade Required', { status: 426 });
     }
     const { socket, response } = Deno.upgradeWebSocket(req, {
       protocol: GRAPHQL_TRANSPORT_WS_PROTOCOL,