Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip jumping when hovering over icons and other not fully fill… #101

Merged
merged 1 commit into from
Jan 9, 2016
Merged

Fix tooltip jumping when hovering over icons and other not fully fill… #101

merged 1 commit into from
Jan 9, 2016

Conversation

pavelloz
Copy link
Contributor

@pavelloz pavelloz commented Jan 6, 2016

…ed elements

When you hover at left nav icons you can clearly see when tooltip is disappearing. It's exactly in pixels where path of the SVG icons is not present. Changing data-effect to float seems to fix this behavior.

Additionally, tooltip is now following the mice which is kind of nice. (Rhyme not intended)

@enjalot enjalot merged commit a7d455a into enjalot:master Jan 9, 2016
@enjalot
Copy link
Owner

enjalot commented Jan 9, 2016

this is an elegant fix and makes things feel much better. thanks 👍
+:100: for rhyming PR!

@enjalot
Copy link
Owner

enjalot commented Jan 9, 2016

unfortunately this uncovered a bug in react-tooltip which I have submitted a PR for: ReactTooltip/react-tooltip#68
I will have make a couple of them "solid" until the PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants