Remove ostruct dependency from specs #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in Ruby 3.4, the following deprecation warning is printed when running the childprocess specs: > childprocess/spec/spec_helper.rb:14: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add ostruct to your Gemfile or gemspec. This commit fixes this warning by removing our dependency on the `ostruct` gem entirely, replacing it with a normal `Struct`.
|
Thanks! Test failures seem unrelated. |
|
Thanks! |
|
The failures are because ruby < 2.6 can't be build on macos-arm64, on macos-latest magically moved to arm64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in Ruby 3.4, the following deprecation warning is printed when running the childprocess specs:
This commit fixes this warning by removing the dependency on the
ostructgem entirely, replacing it with a normalStruct.