Fix usage with C++17 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using with C++17 I got the following error:
ev++.h:355:46: error: ISO C++1z does not allow dynamic exception specifications
dynamic_loop (unsigned int flags = AUTO) throw (bad_loop)
This patch fixes the error by replacing `throw (bad_loop)`
with `noexcept(false)`.
asfgit
pushed a commit
to apache/kudu
that referenced
this pull request
Nov 30, 2020
This patch adjust the build to start supporting and requiring C++17 (therefore GCC 7+). It adjusts the documentation and supported OS matrix to match the new requirements as well. I needed to replace std::random_shuffle with std::shuffle. In C++14 `std::random_shuffle` is deprectated and in C++17 it is removed all together. This patch replaces `std::random_shuffle` with `std::shuffle` passing in a generator. Additionally I needed to patch libev due to a small C++17 incompatibility: enki/libev#8 Change-Id: I15312473bda8c743eac228cd23c337fae5acf99d Reviewed-on: http://gerrit.cloudera.org:8080/16776 Reviewed-by: Attila Bukor <abukor@apache.org> Tested-by: Grant Henke <granthenke@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using with C++17 I got the following error:
ev++.h:355:46: error: ISO C++1z does not allow dynamic exception specifications
dynamic_loop (unsigned int flags = AUTO) throw (bad_loop)
This patch fixes the error by replacing
throw (bad_loop)with
noexcept(false).