clean(core): Address TODO in ThingObjectClassConverter

enola-dev · Jun 22, 2024 · ae2e031 · ae2e031
1 parent 64abfdb
commit ae2e031
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/java/dev/enola/thing/ThingObjectClassConverter.java b/java/dev/enola/thing/ThingObjectClassConverter.java
@@ -19,20 +19,22 @@
 
 import dev.enola.common.convert.*;
 
-// TODO Make this extensible? E.g. using ServiceLoader.
 class ThingObjectClassConverter extends ObjectClassConverterChain {
 
     static ObjectClassConverter INSTANCE = new ThingObjectClassConverter();
 
     private ThingObjectClassConverter() {
+        // TODO Auto-discover Converters; e.g. with ServiceLoader #extensibility
         super(
                 new IdentityObjectClassConverter(),
                 new ObjectConverter<>(Link.class, String.class, link -> link.iri()),
                 new ObjectConverter<>(LangString.class, String.class, in -> in.text()),
-                // TODO Following is all wrong, and only works by chance, because it's last...
-                // ObjectToStringBiConverters must be fixed to consider the type, before toString!
-                // If PredicatesObjects getOptional() would use the Datatype, we wouldn't need this!
-                ObjectToStringBiConverters.INSTANT);
-        // TODO Auto-discover ObjectToStringBiConverters.BOOLEAN, .INT, .URI, .LOCAL_DATE ?
+                // If PredicatesObjects getOptional() would use the Datatype, we wouldn't need this:
+                ObjectToStringBiConverters.BOOLEAN,
+                ObjectToStringBiConverters.INT,
+                ObjectToStringBiConverters.INSTANT,
+                ObjectToStringBiConverters.LOCAL_DATE,
+                ObjectToStringBiConverters.URI,
+                ObjectToStringBiConverters.STRING);
     }
 }