Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go_sdk.host() leads to unstable unreproducible builds #713

Closed
vorburger opened this issue Jun 21, 2024 · 1 comment · Fixed by #715
Closed

go_sdk.host() leads to unstable unreproducible builds #713

vorburger opened this issue Jun 21, 2024 · 1 comment · Fixed by #715
Labels
bug Something isn't working build Build, CI, etc. (w.o. #testing) contributors Affects Contributors (not users) go Go.dev #golang help wanted Extra attention is needed

Comments

@vorburger
Copy link
Member

Expected Behavior

Builds just always just work.

Actual Behavior

Builds regularly break unexpectedly, whenever the version of Go on the host changes; see #626.

Required solution

Replace the go_sdk.host() here with a "fixed version of a remote go toolchain".
@vorburger vorburger added bug Something isn't working help wanted Extra attention is needed build Build, CI, etc. (w.o. #testing) go Go.dev #golang contributors Affects Contributors (not users) labels Jun 21, 2024
@vorburger vorburger mentioned this issue Jun 21, 2024
Closed
vorburger added a commit to vorburger/enola that referenced this issue Jun 21, 2024
@vorburger
build(deps): Use fixed Go v1.22.4 instead go_sdk.host (fixes enola-de…
1ca46d6 
…v#713)
@vorburger vorburger mentioned this issue Jun 21, 2024
Merged
vorburger added a commit to vorburger/enola that referenced this issue Jun 21, 2024
@vorburger
build(deps): Use fixed Go v1.22.4 instead go_sdk.host (fixes enola-de…
450e27e 
…v#713)
vorburger added a commit to vorburger/rules_go that referenced this issue Jun 21, 2024
@vorburger
docs: Discourage use go_sdk.host() in bzlmod.md (see bazel-contrib#713
d57b5c2 
)

see enola-dev/enola#713
@vorburger vorburger mentioned this issue Jun 21, 2024
Merged
vorburger added a commit that referenced this issue Jun 21, 2024
@vorburger
build(deps): Use fixed Go v1.22.4 instead go_sdk.host (fixes #713)
7c39e42
vorburger added a commit to vorburger/rules_go that referenced this issue Jun 21, 2024
@vorburger
docs: Discourage use go_sdk.host() in bzlmod.md (see bazel-contrib#…
4dc7213 
…3967)

see bazel-contrib#3967

and enola-dev/enola#713
@vorburger
Copy link
Member Author

#715 fixed this problem locally for this project.

bazel-contrib/rules_go#3967 raised for an "upstream" discussion about this problem (with bazel-contrib/rules_go#3968).

fmeum pushed a commit to bazel-contrib/rules_go that referenced this issue Jun 21, 2024
@vorburger
docs: Discourage use go_sdk.host() in bzlmod.md (see #3967) (#3968)
93f29a5 
see #3967

and enola-dev/enola#713
@albertocavalcante albertocavalcante mentioned this issue Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working build Build, CI, etc. (w.o. #testing) contributors Affects Contributors (not users) go Go.dev #golang help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use fixed Go v1.22.4 instead go_sdk.host vorburger/enola
1 participant
@vorburger