Java from Bazel Toolchain #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorburger
force-pushed
the
java_from_toolchain
branch
6 times, most recently
from
e2eb21b
to
d38f40e
Compare
vorburger
force-pushed
the
java_from_toolchain
branch
2 times, most recently
from
6eef76e
to
f95da30
Compare
As-is, this makes ./enola noticeable slower; I'll optimize it in a follow-up. There is also some more clean-up possible based on this; that will come in enola-dev#553 on another day.
vorburger
force-pushed
the
java_from_toolchain
branch
from
f95da30
to
c08af1e
Compare
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to (and is initially fix for) #546.
But as-is, this makes
./enolanoticeable slower (because it invokes Bazel x2); I'll optimize it in a follow-up.There is also some more clean-up possible based on this; that will come in #553, on another day.