Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable http compression by default #10342

Closed
rymsha opened this issue Nov 28, 2023 · 2 comments · Fixed by #10820
Closed

Disable http compression by default #10342

rymsha opened this issue Nov 28, 2023 · 2 comments · Fixed by #10820
Assignees
@anatol-sialitski
Labels
Improvement
Milestone
7.15.0

Comments

@rymsha
Copy link
Contributor

rymsha commented Nov 28, 2023

  • Jetty compression module only supports gzip, not br
  • Jetty compression performance is likely worse than apache mod_deflate
  • Jetty compression breaks XP range headers support
  • Azure front door doesn't support large chunked responses and fails because jetty compression uses chunked responses (actually, all implementations do, but it is hard to debug when compression is done by XP)

Some more information why proxy should be a choice for compression
https://learn.microsoft.com/en-us/aspnet/core/performance/response-compression

We must turn compression off in XP and recommend using mod_deflate and alternatives
@rymsha rymsha self-assigned this Nov 28, 2023
@rymsha
Copy link
Contributor Author

rymsha commented Nov 29, 2023

https://developers.cloudflare.com/speed/optimization/content/brotli/content-compression/

@rymsha
Copy link
Contributor Author

rymsha commented Nov 29, 2023

https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/ServingCompressedFiles.html

@rymsha rymsha added this to the 7.15.0 milestone Dec 16, 2024
@rymsha rymsha assigned anatol-sialitski and unassigned rymsha Dec 16, 2024
anatol-sialitski added a commit that referenced this issue Dec 18, 2024
@anatol-sialitski
Disable http compression by default #10342
9e87a87
@anatol-sialitski anatol-sialitski linked a pull request Dec 18, 2024 that will close this issue
Disable http compression by default #10342 #10820
Merged
rymsha pushed a commit that referenced this issue Dec 18, 2024
@anatol-sialitski
Disable http compression by default #10342 (#10820)
631f853
rymsha pushed a commit that referenced this issue Dec 18, 2024
@anatol-sialitski @rymsha
Disable http compression by default #10342 (#10820)
2286e4b 
(cherry picked from commit 631f853)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anatol-sialitski anatol-sialitski

Labels
Improvement
Projects
None yet
Milestone
7.15.0
Development

Successfully merging a pull request may close this issue.

Disable http compression by default #10342 enonic/xp
2 participants
@rymsha @anatol-sialitski