Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving publish dependencies with a huge excludeContentIds list #10635

Closed
vbradnitski opened this issue Jul 9, 2024 · 2 comments · Fixed by #10636
Closed

Resolving publish dependencies with a huge excludeContentIds list #10635

vbradnitski opened this issue Jul 9, 2024 · 2 comments · Fixed by #10636
Assignees
@vbradnitski
Labels
Bug
Milestone
7.14.4

Comments

@vbradnitski
Copy link
Contributor

if it's more than 1024 elements there, ES fails
@vbradnitski vbradnitski added the Bug label Jul 9, 2024
@vbradnitski vbradnitski self-assigned this Jul 9, 2024
@vbradnitski
Copy link
Contributor Author

related to #10623

@vbradnitski
Copy link
Contributor Author

vbradnitski commented Jul 10, 2024 •
edited
Loading

The problem is in "more than 1024" causes a tricky NodeVersionDiffQuery for ExcludeEntries, maybe we can reimplement it to do a filtering instead of a query

@alansemenov alansemenov changed the title Resolving push dependencies with a huge excludeContentIds list Resolving publish dependencies with a huge excludeContentIds list Jul 10, 2024
vbradnitski added a commit that referenced this issue Jul 10, 2024
@vbradnitski
Resolving publish dependencies with a huge excludeContentIds list #10635
7b23ee2
@vbradnitski vbradnitski linked a pull request Jul 10, 2024 that will close this issue
Resolving publish dependencies with a huge excludeContentIds list #10635 #10636
Merged
vbradnitski added a commit that referenced this issue Jul 10, 2024
@vbradnitski
Resolving publish dependencies with a huge excludeContentIds list #10635
64dea8f
vbradnitski added a commit that referenced this issue Jul 10, 2024
@vbradnitski
Resolving publish dependencies with a huge excludeContentIds list #10635
4c2daa5
@rymsha rymsha added this to the 7.14.4 milestone Aug 6, 2024
rymsha pushed a commit that referenced this issue Aug 6, 2024
@vbradnitski @rymsha
Resolving publish dependencies with a huge excludeContentIds list #10635
062ca3a
rymsha pushed a commit that referenced this issue Aug 6, 2024
@vbradnitski @rymsha
Resolving publish dependencies with a huge excludeContentIds list #10635
1c33770
rymsha pushed a commit that referenced this issue Aug 6, 2024
@vbradnitski @rymsha
Resolving publish dependencies with a huge excludeContentIds list #10635
86100d1 


(cherry picked from commit 062ca3a)
rymsha pushed a commit that referenced this issue Aug 6, 2024
@vbradnitski @rymsha
Resolving publish dependencies with a huge excludeContentIds list #10635
dcae793 


(cherry picked from commit 1c33770)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vbradnitski vbradnitski

Labels
Bug
Projects
None yet
Milestone
7.14.4
Development

Successfully merging a pull request may close this issue.

Resolving publish dependencies with a huge excludeContentIds list #10635 enonic/xp
2 participants
@rymsha @vbradnitski