Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressive images support #10642

Closed
rymsha opened this issue Aug 9, 2024 · 3 comments · Fixed by #10643
Closed

Progressive images support #10642

rymsha opened this issue Aug 9, 2024 · 3 comments · Fixed by #10643
Assignees
Labels
Milestone

Comments

@rymsha
Copy link
Contributor

rymsha commented Aug 9, 2024

XP Image should support progressive image conversion by leveraging ImageWriteParam.setProgressiveMode

Configure globally com.enonic.xp.image.cfg progressive = jpeg,png,gif
Don't provide url configuration parameter (at least for now)
Enable progressive by default for jpeg, disable for png and gif by default progressive = jpeg

@rymsha rymsha added the Feature label Aug 9, 2024
@rymsha rymsha self-assigned this Aug 9, 2024
rymsha added a commit that referenced this issue Aug 9, 2024
@rymsha
Copy link
Contributor Author

rymsha commented Aug 9, 2024

progressive JPEGs are small (often smaller) in size! (but for GIF and PNG opposite is true )
progressive JPEG use just a bit extra CPU on clients
developers often use blur placeholder on missing feature of progressive webp - as an alternative for progressive jpeg
for good-old tag without javascript (when your site is not headless) there is no good blur placeholder solution ( is deprecated)

@rymsha rymsha added this to the 8.0.0 milestone Aug 9, 2024
@rymsha rymsha linked a pull request Aug 9, 2024 that will close this issue
@rymsha
Copy link
Contributor Author

rymsha commented Aug 9, 2024

There is a lot of debate if progressive images are good or bad. So we make this feature configurable.

@rymsha
Copy link
Contributor Author

rymsha commented Aug 9, 2024

Documentation note: it is not sufficient to turn on/off the progressive parameter. Image cache must be cleared manually.

rymsha added a commit that referenced this issue Aug 15, 2024
@rymsha rymsha modified the milestones: 8.0.0, 7.15.0 Sep 18, 2024
rymsha added a commit that referenced this issue Dec 3, 2024
(cherry picked from commit 83e51f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant