Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnapshotServiceImpl: no error/warning on failed snapshot deletion #10676

Closed
ashklianko opened this issue Sep 6, 2024 · 0 comments · Fixed by #10803 or #10805
Closed

SnapshotServiceImpl: no error/warning on failed snapshot deletion #10676

ashklianko opened this issue Sep 6, 2024 · 0 comments · Fixed by #10803 or #10805
Assignees
Labels
Milestone

Comments

@ashklianko
Copy link
Member

App-snapshotter runs scheduled cleanup once an hour by default, and that cleanup may fail silently in elastic with no trace in our logs if other snapshot is being created in the moment. I managed to manually reproduce the issue and catch the exception:
ConcurrentSnapshotExecutionException[[enonic-xp-snapshot-repo:com.enonic.app.snapshotter--hourly2_2024-09-06t07_34_00.244781700z] another snapshot is currently running cannot delete]

Can wrap invocation of doDeleteSnapshot with try-catch block and logging within, or maybe the team can propose other solutions to this.

@ashklianko ashklianko added the Bug label Sep 6, 2024
@rymsha rymsha added this to the 7.15.0 milestone Dec 3, 2024
anatol-sialitski added a commit that referenced this issue Dec 11, 2024
No error/warning on failed snapshot deletion #10676
anatol-sialitski added a commit that referenced this issue Dec 11, 2024
No error/warning on failed snapshot deletion #10676
ashklianko pushed a commit that referenced this issue Dec 13, 2024
No error/warning on failed snapshot deletion #10676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants