Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the scope argument in the repo modify function #10774

Closed
anatol-sialitski opened this issue Nov 30, 2024 · 0 comments · Fixed by #10786
Closed

Deprecate the scope argument in the repo modify function #10774

anatol-sialitski opened this issue Nov 30, 2024 · 0 comments · Fixed by #10786
Assignees
@anatol-sialitski
Labels
Improvement
Milestone
7.15.0

Comments

@anatol-sialitski
Copy link
Contributor

anatol-sialitski commented Nov 30, 2024 •
edited by rymsha
Loading

scope was probably copy-pasted from modifyProfile api in lib-auth. While method modifyUser never had scope

JS doc is also incorrect and scope was never limiting fetched data - it was always entire repo object - thus it was unusable: entire editor's result was put in data filed in "scope".

Mark the scope argument as deprecated in the modify function of the repo library.
@anatol-sialitski anatol-sialitski self-assigned this Nov 30, 2024
anatol-sialitski added a commit that referenced this issue Nov 30, 2024
@anatol-sialitski
Deprecate the scope argument in the modify function #10774
5efc30a
@rymsha rymsha changed the title Deprecate the scope argument in the modify function Deprecate the scope argument in the repo modify function Nov 30, 2024
anatol-sialitski added a commit that referenced this issue Dec 2, 2024
@anatol-sialitski
Deprecate the scope argument in the modify function #10774
0a12f82
anatol-sialitski added a commit that referenced this issue Dec 2, 2024
@anatol-sialitski
Deprecate the scope argument in the modify function #10774
123c62a
anatol-sialitski added a commit that referenced this issue Dec 2, 2024
@anatol-sialitski
Deprecate the scope argument in the modify function #10774
fad5d17
anatol-sialitski added a commit that referenced this issue Dec 3, 2024
@anatol-sialitski
Deprecate the scope argument in the modify function #10774
b214e34 
(cherry picked from commit fad5d17)
@anatol-sialitski anatol-sialitski linked a pull request Dec 3, 2024 that will close this issue
Deprecate the scope argument in the modify function #10774 #10786
Merged
anatol-sialitski added a commit that referenced this issue Dec 3, 2024
@anatol-sialitski
Deprecate the scope argument in the modify function #10774
e028196 
(cherry picked from commit fad5d17)
@rymsha rymsha added this to the 7.15.0 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anatol-sialitski anatol-sialitski

Labels
Improvement
Projects
None yet
Milestone
7.15.0
Development

Successfully merging a pull request may close this issue.

Deprecate the scope argument in the modify function #10774 enonic/xp
2 participants
@rymsha @anatol-sialitski