Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fragment and Image component return 200 when content is missing #10822

Closed
rymsha opened this issue Dec 20, 2024 · 0 comments · Fixed by #10823
Closed

Fragment and Image component return 200 when content is missing #10822

rymsha opened this issue Dec 20, 2024 · 0 comments · Fixed by #10823
Assignees
@rymsha
Labels
Bug
Milestone
7.15.0

Comments

@rymsha
Copy link
Contributor

rymsha commented Dec 20, 2024 •
edited
Loading

This is similar to #10682 . Difference is that in case of missing content 404 should be returned
@rymsha rymsha added this to the 7.15.0 milestone Dec 20, 2024
@rymsha rymsha self-assigned this Dec 20, 2024
@rymsha rymsha changed the title Fragment and Image component renderers return 200 even when content is missing Fragment and Image component return 200 when content is missing Dec 20, 2024
rymsha added a commit that referenced this issue Dec 20, 2024
@rymsha
Fragment and Image component return 200 when content is missing #10822
75bfecb
rymsha added a commit that referenced this issue Dec 20, 2024
@rymsha
Revert "Fragment and Image component return 200 when content is missing
5ca8d7e 
#10822"

This reverts commit 75bfecb.
rymsha added a commit that referenced this issue Dec 20, 2024
@rymsha
Fragment and Image component return 200 when content is missing #10822
066fada 
(cherry picked from commit 75bfecb)
@rymsha rymsha linked a pull request Dec 20, 2024 that will close this issue
Fragment and Image component return 200 when content is missing #10822 #10823
Merged
rymsha added a commit that referenced this issue Dec 20, 2024
@rymsha
Fragment and Image component return 200 when content is missing #10822
6313231
rymsha added a commit that referenced this issue Dec 20, 2024
@rymsha
Fragment and Image component return 200 when content is missing #10822 (
e5e9202 
#10823)
rymsha added a commit that referenced this issue Dec 20, 2024
@rymsha
Fragment and Image component return 200 when content is missing #10822 (
e3c8b29 
#10823)

(cherry picked from commit e5e9202)
@rymsha rymsha added Bug and removed Improvement labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rymsha rymsha

Labels
Bug
Projects
None yet
Milestone
7.15.0
Development

Successfully merging a pull request may close this issue.

Fragment and Image component return 200 when content is missing #10822 enonic/xp
1 participant
@rymsha