Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Trace for Content and Node API #10033 #10035

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Improve Trace for Content and Node API #10033 #10035

merged 2 commits into from
Feb 9, 2023

Conversation

rymsha
Copy link
Contributor

@rymsha rymsha commented Feb 8, 2023

No description provided.

@@ -521,6 +525,43 @@
assertThrows( OperationNotPermittedException.class, () -> nodeService.delete( DeleteNodeParams.create().nodeId( Node.ROOT_UUID ).build() ) );
}

@Test
void nodes_has_children()

Check notice

Code scanning / Pmd (reported by Codacy)

The JUnit 5 test method name 'nodes_has_children' doesn't match '[a-z][a-zA-Z0-9]*'

The JUnit 5 test method name 'nodes_has_children' doesn't match '[a-z][a-zA-Z0-9]*'
@rymsha rymsha marked this pull request as ready for review February 8, 2023 16:52
@@ -70,17 +87,72 @@
}

@Test
public void traceNull()
void traceNull()

Check warning

Code scanning / Pmd (reported by Codacy)

JUnit tests should include assert() or fail()

JUnit tests should include assert() or fail()
}

@Test
void trace_enabled( @Mock final Consumer<Trace> before, @Mock final Supplier<Object> call )

Check warning

Code scanning / Pmd (reported by Codacy)

JUnit tests should include assert() or fail()

JUnit tests should include assert() or fail()
}

@Test
void trace_enabled( @Mock final Consumer<Trace> before, @Mock final BiConsumer<Trace, Object> after, @Mock final Supplier<Object> call )

Check warning

Code scanning / Pmd (reported by Codacy)

JUnit tests should include assert() or fail()

JUnit tests should include assert() or fail()
}

@Test
void trace_enabled( @Mock final Consumer<Trace> before, @Mock final Supplier<Object> call )

Check notice

Code scanning / Pmd (reported by Codacy)

The JUnit 5 test method name 'trace_enabled' doesn't match '[a-z][a-zA-Z0-9]*'

The JUnit 5 test method name 'trace_enabled' doesn't match '[a-z][a-zA-Z0-9]*'
}

@Test
void trace_enabled( @Mock final Consumer<Trace> before, @Mock final BiConsumer<Trace, Object> after, @Mock final Supplier<Object> call )

Check notice

Code scanning / Pmd (reported by Codacy)

The JUnit 5 test method name 'trace_enabled' doesn't match '[a-z][a-zA-Z0-9]*'

The JUnit 5 test method name 'trace_enabled' doesn't match '[a-z][a-zA-Z0-9]*'
}

@Test
void trace_disabled( @Mock final Consumer<Trace> before, @Mock final Supplier<Object> call )

Check notice

Code scanning / Pmd (reported by Codacy)

The JUnit 5 test method name 'trace_disabled' doesn't match '[a-z][a-zA-Z0-9]*'

The JUnit 5 test method name 'trace_disabled' doesn't match '[a-z][a-zA-Z0-9]*'
{
Tracer.trace( (Trace) null, () ->
{
} );
}

@Test
public void testTrace()
void trace_disabled( @Mock final Consumer<Trace> before, @Mock final BiConsumer<Trace, Object> after, @Mock final Supplier<Object> call )

Check notice

Code scanning / Pmd (reported by Codacy)

The JUnit 5 test method name 'trace_disabled' doesn't match '[a-z][a-zA-Z0-9]*'

The JUnit 5 test method name 'trace_disabled' doesn't match '[a-z][a-zA-Z0-9]*'
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 84.01% // Head: 84.07% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (807cc40) compared to base (5640633).
Patch coverage: 65.12% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10035      +/-   ##
============================================
+ Coverage     84.01%   84.07%   +0.05%     
  Complexity    19310    19310              
============================================
  Files          2582     2582              
  Lines         67825    67773      -52     
  Branches       5471     5451      -20     
============================================
- Hits          56986    56982       -4     
+ Misses         8129     8096      -33     
+ Partials       2710     2695      -15     
Impacted Files Coverage Δ
...ava/com/enonic/xp/node/NodesHasChildrenResult.java 64.28% <ø> (-35.72%) ⬇️
...l/content/GetContentByPathAndVersionIdCommand.java 100.00% <ø> (ø)
...in/java/com/enonic/xp/lib/node/GetNodeHandler.java 67.56% <ø> (ø)
...nonic/xp/core/impl/content/ContentServiceImpl.java 78.15% <51.51%> (+3.66%) ⬆️
.../com/enonic/xp/repo/impl/node/NodeServiceImpl.java 80.20% <66.66%> (+2.50%) ⬆️
...in/java/com/enonic/xp/node/MultiRepoNodeQuery.java 100.00% <100.00%> (ø)
...-api/src/main/java/com/enonic/xp/trace/Tracer.java 90.47% <100.00%> (+2.72%) ⬆️
...ic/xp/core/impl/content/ContentNodeTranslator.java 90.69% <100.00%> (-0.22%) ⬇️
...enonic/xp/repo/impl/node/NodeHasChildResolver.java 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rymsha rymsha merged commit e147c3d into master Feb 9, 2023
@rymsha rymsha deleted the issue-10033 branch February 9, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants