Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fragment config isn't indexed by pages #10047 #10050

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

vbradnitski
Copy link
Contributor

No description provided.

@@ -54,22 +54,23 @@

private Form configFormWithHtmlArea;

private Form configFormWithTextInput;

Check warning

Code scanning / Pmd (reported by Codacy)

Avoid unused private fields such as 'configFormWithTextInput'.

Avoid unused private fields such as 'configFormWithTextInput'.
@@ -54,22 +54,23 @@

private Form configFormWithHtmlArea;

private Form configFormWithTextInput;

Check warning

Code scanning / Pmd (reported by Codacy)

Perhaps 'configFormWithTextInput' could be replaced by a local variable.

Perhaps 'configFormWithTextInput' could be replaced by a local variable.
@@ -221,6 +209,42 @@

}

@Test
public void test_fragment_page()

Check notice

Code scanning / Pmd (reported by Codacy)

The JUnit 5 test method name 'test_fragment_page' doesn't match '[a-z][a-zA-Z0-9]*'

The JUnit 5 test method name 'test_fragment_page' doesn't match '[a-z][a-zA-Z0-9]*'
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 84.06% // Head: 84.07% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5b28cba) compared to base (d7a2239).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #10050   +/-   ##
=========================================
  Coverage     84.06%   84.07%           
- Complexity    19310    19313    +3     
=========================================
  Files          2582     2582           
  Lines         67781    67785    +4     
  Branches       5453     5453           
=========================================
+ Hits          56982    56988    +6     
+ Misses         8103     8102    -1     
+ Partials       2696     2695    -1     
Impacted Files Coverage Δ
...nt/index/processor/PageRegionsConfigProcessor.java 88.00% <100.00%> (+1.04%) ⬆️
...xp/repo/impl/branch/storage/BranchServiceImpl.java 94.49% <0.00%> (+1.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vbradnitski vbradnitski merged commit 742b26c into master Feb 24, 2023
@vbradnitski vbradnitski deleted the issue-10047 branch February 24, 2023 16:08
rymsha pushed a commit that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants